diff --git a/llvm/lib/Transforms/Scalar/MergeICmps.cpp b/llvm/lib/Transforms/Scalar/MergeICmps.cpp index 283e9029571a..3306f605ac7c 100644 --- a/llvm/lib/Transforms/Scalar/MergeICmps.cpp +++ b/llvm/lib/Transforms/Scalar/MergeICmps.cpp @@ -248,9 +248,9 @@ private: bool BCECmpBlock::canSinkBCECmpInst(const Instruction *Inst, DenseSet &BlockInsts, AliasAnalysis &AA) const { - // If this instruction has side effects and its in middle of the BCE cmp block - // instructions, then bail for now. - if (Inst->mayHaveSideEffects()) { + // If this instruction may clobber the loads and is in middle of the BCE cmp + // block instructions, then bail for now. + if (Inst->mayWriteToMemory()) { // Bail if this is not a simple load or store if (!isSimpleLoadOrStore(Inst)) return false; diff --git a/llvm/test/Transforms/MergeICmps/X86/split-block-does-work.ll b/llvm/test/Transforms/MergeICmps/X86/split-block-does-work.ll index cb911ebbf125..0b9663f44980 100644 --- a/llvm/test/Transforms/MergeICmps/X86/split-block-does-work.ll +++ b/llvm/test/Transforms/MergeICmps/X86/split-block-does-work.ll @@ -3,7 +3,7 @@ %S = type { i32, i32, i32, i32 } -declare void @foo(...) nounwind readnone +declare void @foo(...) readonly ; We can split %entry and create a memcmp(16 bytes). define zeroext i1 @opeq1(