maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[test][NFC] Do ptrdiff_t comparison with signed instead of unsigned constants 

... because using unsigned constants for comparing against signed values
is liable to mutate the signed value via conversion to an unsigned type
due to the usual arithmetic conversions.
This commit is contained in:
Hubert Tong 2020-10-17 22:22:43 -04:00
parent 6de8d7f1ad
commit f4d8e86dbe
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp
View File

@ -200,7 +200,7 @@ TEST(DWARFDebugArangeSet, ZeroAddressEntry) {
Succeeded());
auto Range = Set.descriptors();
auto Iter = Range.begin();
ASSERT_EQ(std::distance(Iter, Range.end()), 1u);
ASSERT_EQ(std::distance(Iter, Range.end()), 1);
EXPECT_EQ(Iter->Address, 0u);
EXPECT_EQ(Iter->Length, 1u);
}
@ -227,7 +227,7 @@ TEST(DWARFDebugArangeSet, ZeroLengthEntry) {
Succeeded());
auto Range = Set.descriptors();
auto Iter = Range.begin();
ASSERT_EQ(std::distance(Iter, Range.end()), 1u);
ASSERT_EQ(std::distance(Iter, Range.end()), 1);
EXPECT_EQ(Iter->Address, 1u);
EXPECT_EQ(Iter->Length, 0u);
}
@ -256,7 +256,7 @@ TEST(DWARFDebugArangesSet, PrematureTerminator) {
ASSERT_THAT_ERROR(Set.extract(Extractor, &Offset, Warnings), Succeeded());
auto Range = Set.descriptors();
auto Iter = Range.begin();
ASSERT_EQ(std::distance(Iter, Range.end()), 2u);
ASSERT_EQ(std::distance(Iter, Range.end()), 2);
EXPECT_EQ(Iter->Address, 0u);
EXPECT_EQ(Iter->Length, 0u);
++Iter;