maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix a bug: this does not preserve the CFG! 

While we're at it, add support for updating loop information correctly.

llvm-svn: 13033
This commit is contained in:
Chris Lattner 2004-04-18 05:38:37 +00:00
parent 1472c63fb9
commit f2cc841619
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
llvm/lib/Transforms/Scalar/LoopUnroll.cpp
View File

@ -47,9 +47,9 @@ namespace {
/// loop preheaders be inserted into the CFG... /// loop preheaders be inserted into the CFG...
/// ///
virtual void getAnalysisUsage(AnalysisUsage &AU) const { virtual void getAnalysisUsage(AnalysisUsage &AU) const {
AU.setPreservesCFG();
AU.addRequiredID(LoopSimplifyID); AU.addRequiredID(LoopSimplifyID);
AU.addRequired<LoopInfo>(); AU.addRequired<LoopInfo>();
AU.addPreserved<LoopInfo>();
} }
}; };
RegisterOpt<LoopUnroll> X("loop-unroll", "Unroll loops"); RegisterOpt<LoopUnroll> X("loop-unroll", "Unroll loops");
@ -61,8 +61,11 @@ bool LoopUnroll::runOnFunction(Function &F) {
bool Changed = false; bool Changed = false;
LI = &getAnalysis<LoopInfo>(); LI = &getAnalysis<LoopInfo>();
for (LoopInfo::iterator I = LI->begin(), E = LI->end(); I != E; ++I) // Transform all the top-level loops. Copy the loop list so that the child
Changed |= visitLoop(*I); // can update the loop tree if it needs to delete the loop.
std::vector<Loop*> SubLoops(LI->begin(), LI->end());
for (unsigned i = 0, e = SubLoops.size(); i != e; ++i)
Changed |= visitLoop(SubLoops[i]);
return Changed; return Changed;
} }
@ -238,7 +241,20 @@ bool LoopUnroll::visitLoop(Loop *L) {
} }
} }
// FIXME: Should update analyses // Update the loop information for this loop.
Loop *Parent = L->getParentLoop();
// Move all of the basic blocks in the loop into the parent loop.
LI->changeLoopFor(BB, Parent);
// Remove the loop from the parent.
if (Parent)
delete Parent->removeChildLoop(std::find(Parent->begin(), Parent->end(),L));
else
delete LI->removeLoop(std::find(LI->begin(), LI->end(), L));
// FIXME: Should update dominator analyses
// FIXME: Should fold into preheader and exit block // FIXME: Should fold into preheader and exit block