maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Attempt at fixing a crasher where summary strings where looping endlessly. 

llvm-svn: 154028
This commit is contained in:
Enrico Granata 2012-04-04 17:34:10 +00:00
parent 0249fba8c3
commit f18c03e49e
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lldb/include/lldb/Core/ValueObject.h
View File

@ -966,7 +966,6 @@ public:
{
m_type_summary_sp = format;
ClearUserVisibleData(eClearUserVisibleDataItemsSummary);
m_is_getting_summary = false;
}
void

9
lldb/source/Core/ValueObject.cpp
View File

@ -671,6 +671,14 @@ ValueObject::GetSummaryAsCString (TypeSummaryImpl* summary_ptr,
return false;
m_is_getting_summary = true;
// this is a hot path in code and we prefer to avoid setting this string all too often also clearing out other
// information that we might care to see in a crash log. might be useful in very specific situations though.
/*Host::SetCrashDescriptionWithFormat("Trying to fetch a summary for %s %s. Summary provider's description is %s",
GetTypeName().GetCString(),
GetName().GetCString(),
summary_ptr->GetDescription().c_str());*/
if (UpdateValueIfNeeded (false))
{
if (summary_ptr)
@ -3928,7 +3936,6 @@ ValueObject::ClearUserVisibleData(uint32_t clear_mask)
if ((clear_mask & eClearUserVisibleDataItemsSummary) == eClearUserVisibleDataItemsSummary)
{
m_is_getting_summary = false;
m_summary_str.clear();
}