maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang][nfc] Fix comments, remove needless API, tweak script 

* Remove an unimplemented and unused member function declaration
* Remove a misleading comment about an unrelated constraint number
* Fix a comment
* Add f18 crash message to "flang" driver script

Differential Revision: https://reviews.llvm.org/D95180
This commit is contained in:
peter klausler 2021-01-21 14:59:43 -08:00
parent 520b5ecf85
commit f187d64c80
4 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
flang/include/flang/Parser/provenance.h
View File

@ -173,7 +173,6 @@ public:
std::string GetPath(Provenance) const; // __FILE__ std::string GetPath(Provenance) const; // __FILE__
int GetLineNumber(Provenance) const; // __LINE__ int GetLineNumber(Provenance) const; // __LINE__
Provenance CompilerInsertionProvenance(char ch); Provenance CompilerInsertionProvenance(char ch);
Provenance CompilerInsertionProvenance(const char *, std::size_t);
ProvenanceRange IntersectionWithSourceFiles(ProvenanceRange) const; ProvenanceRange IntersectionWithSourceFiles(ProvenanceRange) const;
llvm::raw_ostream &Dump(llvm::raw_ostream &) const; llvm::raw_ostream &Dump(llvm::raw_ostream &) const;

2
flang/include/flang/Semantics/symbol.h
View File

@ -356,7 +356,7 @@ private:
}; };
// Record the USE of a symbol: location is where (USE statement or renaming); // Record the USE of a symbol: location is where (USE statement or renaming);
// symbol is the USEd module. // symbol is in the USEd module.
class UseDetails { class UseDetails {
public: public:
UseDetails(const SourceName &location, const Symbol &symbol) UseDetails(const SourceName &location, const Symbol &symbol)

2
flang/lib/Semantics/assignment.cpp
View File

@ -70,7 +70,7 @@ void AssignmentContext::Analyze(const parser::AssignmentStmt &stmt) {
const Scope &scope{context_.FindScope(lhsLoc)}; const Scope &scope{context_.FindScope(lhsLoc)};
if (auto whyNot{WhyNotModifiable(lhsLoc, lhs, scope, true)}) { if (auto whyNot{WhyNotModifiable(lhsLoc, lhs, scope, true)}) {
if (auto *msg{Say(lhsLoc, if (auto *msg{Say(lhsLoc,
"Left-hand side of assignment is not modifiable"_err_en_US)}) { // C1158 "Left-hand side of assignment is not modifiable"_err_en_US)}) {
msg->Attach(*whyNot); msg->Attach(*whyNot);
} }
} }

7
flang/tools/f18/flang
View File

@ -12,4 +12,9 @@ module_dir=$wd/include/flang
if [[ ! -d $module_dir ]]; then if [[ ! -d $module_dir ]]; then
module_dir=$wd/tools/flang/include/flang module_dir=$wd/tools/flang/include/flang
fi fi
$wd/bin/f18 -module-suffix .f18.mod -intrinsic-module-directory $module_dir "$@" opts="-module-suffix .f18.mod -intrinsic-module-directory $module_dir"
if ! $wd/bin/f18 $opts "$@"
then status=$?
echo flang: in $PWD, f18 failed with exit status $status: $wd/bin/f18 $opts "$@" >&2
exit $status
fi