ARMTargetParser.cpp - use auto const references in for range loops. NFCI.

Fix static analysis warnings about unnecessary copies.
This commit is contained in:
Simon Pilgrim 2020-09-09 11:17:49 +01:00
parent 24ecfdac7b
commit f16b2d8315
1 changed files with 10 additions and 10 deletions

View File

@ -255,7 +255,7 @@ ARM::ISAKind ARM::parseArchISA(StringRef Arch) {
unsigned ARM::parseFPU(StringRef FPU) { unsigned ARM::parseFPU(StringRef FPU) {
StringRef Syn = getFPUSynonym(FPU); StringRef Syn = getFPUSynonym(FPU);
for (const auto F : FPUNames) { for (const auto &F : FPUNames) {
if (Syn == F.getName()) if (Syn == F.getName())
return F.ID; return F.ID;
} }
@ -409,7 +409,7 @@ bool ARM::getExtensionFeatures(uint64_t Extensions,
if (Extensions == AEK_INVALID) if (Extensions == AEK_INVALID)
return false; return false;
for (const auto AE : ARCHExtNames) { for (const auto &AE : ARCHExtNames) {
if ((Extensions & AE.ID) == AE.ID && AE.Feature) if ((Extensions & AE.ID) == AE.ID && AE.Feature)
Features.push_back(AE.Feature); Features.push_back(AE.Feature);
else if (AE.NegFeature) else if (AE.NegFeature)
@ -436,7 +436,7 @@ unsigned ARM::getArchAttr(ARM::ArchKind AK) {
} }
StringRef ARM::getArchExtName(uint64_t ArchExtKind) { StringRef ARM::getArchExtName(uint64_t ArchExtKind) {
for (const auto AE : ARCHExtNames) { for (const auto &AE : ARCHExtNames) {
if (ArchExtKind == AE.ID) if (ArchExtKind == AE.ID)
return AE.getName(); return AE.getName();
} }
@ -453,7 +453,7 @@ static bool stripNegationPrefix(StringRef &Name) {
StringRef ARM::getArchExtFeature(StringRef ArchExt) { StringRef ARM::getArchExtFeature(StringRef ArchExt) {
bool Negated = stripNegationPrefix(ArchExt); bool Negated = stripNegationPrefix(ArchExt);
for (const auto AE : ARCHExtNames) { for (const auto &AE : ARCHExtNames) {
if (AE.Feature && ArchExt == AE.getName()) if (AE.Feature && ArchExt == AE.getName())
return StringRef(Negated ? AE.NegFeature : AE.Feature); return StringRef(Negated ? AE.NegFeature : AE.Feature);
} }
@ -502,7 +502,7 @@ bool ARM::appendArchExtFeatures(StringRef CPU, ARM::ArchKind AK,
if (ID == AEK_INVALID) if (ID == AEK_INVALID)
return false; return false;
for (const auto AE : ARCHExtNames) { for (const auto &AE : ARCHExtNames) {
if (Negated) { if (Negated) {
if ((AE.ID & ID) == ID && AE.NegFeature) if ((AE.ID & ID) == ID && AE.NegFeature)
Features.push_back(AE.NegFeature); Features.push_back(AE.NegFeature);
@ -535,7 +535,7 @@ bool ARM::appendArchExtFeatures(StringRef CPU, ARM::ArchKind AK,
} }
StringRef ARM::getHWDivName(uint64_t HWDivKind) { StringRef ARM::getHWDivName(uint64_t HWDivKind) {
for (const auto D : HWDivNames) { for (const auto &D : HWDivNames) {
if (HWDivKind == D.ID) if (HWDivKind == D.ID)
return D.getName(); return D.getName();
} }
@ -548,7 +548,7 @@ StringRef ARM::getDefaultCPU(StringRef Arch) {
return StringRef(); return StringRef();
// Look for multiple AKs to find the default for pair AK+Name. // Look for multiple AKs to find the default for pair AK+Name.
for (const auto CPU : CPUNames) { for (const auto &CPU : CPUNames) {
if (CPU.ArchID == AK && CPU.Default) if (CPU.ArchID == AK && CPU.Default)
return CPU.getName(); return CPU.getName();
} }
@ -559,7 +559,7 @@ StringRef ARM::getDefaultCPU(StringRef Arch) {
uint64_t ARM::parseHWDiv(StringRef HWDiv) { uint64_t ARM::parseHWDiv(StringRef HWDiv) {
StringRef Syn = getHWDivSynonym(HWDiv); StringRef Syn = getHWDivSynonym(HWDiv);
for (const auto D : HWDivNames) { for (const auto &D : HWDivNames) {
if (Syn == D.getName()) if (Syn == D.getName())
return D.ID; return D.ID;
} }
@ -567,7 +567,7 @@ uint64_t ARM::parseHWDiv(StringRef HWDiv) {
} }
uint64_t ARM::parseArchExt(StringRef ArchExt) { uint64_t ARM::parseArchExt(StringRef ArchExt) {
for (const auto A : ARCHExtNames) { for (const auto &A : ARCHExtNames) {
if (ArchExt == A.getName()) if (ArchExt == A.getName())
return A.ID; return A.ID;
} }
@ -575,7 +575,7 @@ uint64_t ARM::parseArchExt(StringRef ArchExt) {
} }
ARM::ArchKind ARM::parseCPUArch(StringRef CPU) { ARM::ArchKind ARM::parseCPUArch(StringRef CPU) {
for (const auto C : CPUNames) { for (const auto &C : CPUNames) {
if (CPU == C.getName()) if (CPU == C.getName())
return C.ArchID; return C.ArchID;
} }