maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Windows: Avoiding resizing, use uninitialized data() instead 

This is ever-so faster but more importantly matches what we have elsewhere.

llvm-svn: 192137
This commit is contained in:
David Majnemer 2013-10-07 21:57:07 +00:00
parent 312fcd0e1c
commit f07777c80b
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/Support/Windows/Process.inc
View File

@ -161,8 +161,9 @@ Optional<std::string> Process::GetEnv(StringRef Name) {
SmallVector<wchar_t, MAX_PATH> Buf;
size_t Size = MAX_PATH;
do {
Buf.resize(Size);
Size = GetEnvironmentVariableW(&NameUTF16[0], &Buf[0], Buf.capacity());
Buf.reserve(Size);
Size =
GetEnvironmentVariableW(NameUTF16.data(), Buf.data(), Buf.capacity());
if (Size == 0)
return None;
@ -172,9 +173,9 @@ Optional<std::string> Process::GetEnv(StringRef Name) {
// Convert the result from UTF-16 to UTF-8.
SmallVector<char, MAX_PATH> Res;
if (error_code ec = windows::UTF16ToUTF8(&Buf[0], Size, Res))
if (error_code ec = windows::UTF16ToUTF8(Buf.data(), Size, Res))
return None;
return std::string(&Res[0]);
return std::string(Res.data());
}
error_code