maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer. 

Differential Revision: https://reviews.llvm.org/D89036
This commit is contained in:
Haojian Wu 2020-10-09 08:51:17 +02:00
parent 16580d791f
commit efd8c9ed72
2 changed files with 46 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang-tools-extra/clangd/IncludeFixer.cpp
View File

@ -72,6 +72,12 @@ std::vector<Fix> IncludeFixer::fix(DiagnosticsEngine::Level DiagLevel,
case diag::err_incomplete_base_class: case diag::err_incomplete_base_class:
case diag::err_incomplete_member_access: case diag::err_incomplete_member_access:
case diag::err_incomplete_type: case diag::err_incomplete_type:
case diag::err_typecheck_decl_incomplete_type:
case diag::err_typecheck_incomplete_tag:
case diag::err_invalid_incomplete_type_use:
case diag::err_sizeof_alignof_incomplete_or_sizeless_type:
case diag::err_for_range_incomplete_type:
case diag::err_func_def_incomplete_result:
// Incomplete type diagnostics should have a QualType argument for the // Incomplete type diagnostics should have a QualType argument for the
// incomplete type. // incomplete type.
for (unsigned Idx = 0; Idx < Info.getNumArgs(); ++Idx) { for (unsigned Idx = 0; Idx < Info.getNumArgs(); ++Idx) {

43
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
View File

@ -705,11 +705,18 @@ $insert[[]]namespace ns {
$nested[[X::]]Nested n; $nested[[X::]]Nested n;
} }
class Y : $base[[public ns::X]] {}; class Y : $base[[public ns::X]] {};
int main() { void test(ns::X *x, ns::X& ref_x) {
ns::X *x;
x$access[[->]]f(); x$access[[->]]f();
auto& $type[[[]]a] = *x; auto& $type[[[]]a] = *x;
ns::X $incomplete[[var]];
$tag[[ref_x]]->f();
$use[[ns::X()]];
$sizeof[[sizeof]](ns::X);
for (auto it : $for[[ref_x]]);
} }
ns::X $return[[func]]() {}
)cpp"); )cpp");
auto TU = TestTU::withCode(Test.code()); auto TU = TestTU::withCode(Test.code());
TU.ExtraArgs.push_back("-std=c++17"); TU.ExtraArgs.push_back("-std=c++17");
@ -739,7 +746,37 @@ int main() {
"incomplete type 'ns::X' where a complete type is required"), "incomplete type 'ns::X' where a complete type is required"),
DiagName("incomplete_type"), DiagName("incomplete_type"),
WithFix(Fix(Test.range("insert"), "#include \"x.h\"\n", WithFix(Fix(Test.range("insert"), "#include \"x.h\"\n",
"Add include \"x.h\" for symbol ns::X"))))); "Add include \"x.h\" for symbol ns::X"))),
AllOf(Diag(Test.range("incomplete"),
"variable has incomplete type 'ns::X'"),
DiagName("typecheck_decl_incomplete_type"),
WithFix(Fix(Test.range("insert"), "#include \"x.h\"\n",
"Add include \"x.h\" for symbol ns::X"))),
AllOf(
Diag(Test.range("tag"), "incomplete definition of type 'ns::X'"),
DiagName("typecheck_incomplete_tag"),
WithFix(Fix(Test.range("insert"), "#include \"x.h\"\n",
"Add include \"x.h\" for symbol ns::X"))),
AllOf(
Diag(Test.range("use"), "invalid use of incomplete type 'ns::X'"),
DiagName("invalid_incomplete_type_use"),
WithFix(Fix(Test.range("insert"), "#include \"x.h\"\n",
"Add include \"x.h\" for symbol ns::X"))),
AllOf(Diag(Test.range("sizeof"), "invalid application of 'sizeof' to "
"an incomplete type 'ns::X'"),
DiagName("sizeof_alignof_incomplete_or_sizeless_type"),
WithFix(Fix(Test.range("insert"), "#include \"x.h\"\n",
"Add include \"x.h\" for symbol ns::X"))),
AllOf(Diag(Test.range("for"),
"cannot use incomplete type 'ns::X' as a range"),
DiagName("for_range_incomplete_type"),
WithFix(Fix(Test.range("insert"), "#include \"x.h\"\n",
"Add include \"x.h\" for symbol ns::X"))),
AllOf(Diag(Test.range("return"),
"incomplete result type 'ns::X' in function definition"),
DiagName("func_def_incomplete_result"),
WithFix(Fix(Test.range("insert"), "#include \"x.h\"\n",
"Add include \"x.h\" for symbol ns::X")))));
} }
TEST(IncludeFixerTest, NoSuggestIncludeWhenNoDefinitionInHeader) { TEST(IncludeFixerTest, NoSuggestIncludeWhenNoDefinitionInHeader) {