maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SDAG] Actually check for a non-constant splat and clarify comments 

around the handling of UNDEF lanes in boolean vector content analysis.

The code before my changes here also failed to check for non-constant
splats in a buildvector. I have no idea how to trigger this, I just
spotted by inspection when trying to understand the code. It seems
extremely unlikely to be worth the trouble to teach the only caller of
this code (DAG combining setcc patterns) how to cleverly handle undef
lanes, so I've just commented more thoroughly that we're giving up
there.

llvm-svn: 212515
This commit is contained in:
Chandler Carruth 2014-07-08 07:44:15 +00:00
parent b844e72e85
commit efbce58775
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
View File

@ -1160,8 +1160,10 @@ bool TargetLowering::isConstTrueVal(const SDNode *N) const {
IsVec = true;
bool HasUndefElements;
CN = BV->getConstantSplatNode(HasUndefElements);
if (HasUndefElements)
return false; // Can't blindly collapse the undef values.
// Only interested in constant splats, and we don't try to handle undef
// elements in identifying boolean constants.
if (!CN || HasUndefElements)
return false;
}
switch (getBooleanContents(IsVec)) {
@ -1190,8 +1192,10 @@ bool TargetLowering::isConstFalseVal(const SDNode *N) const {
IsVec = true;
bool HasUndefElements;
CN = BV->getConstantSplatNode(HasUndefElements);
if (HasUndefElements)
return false; // Can't blindly collapse the undef values.
// Only interested in constant splats, and we don't try to handle undef
// elements in identifying boolean constants.
if (!CN || HasUndefElements)
return false;
}
if (getBooleanContents(IsVec) == UndefinedBooleanContent)