maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lld/mac] Delete incorrect FIXME 

"""Bitcode symbols only exist before LTO runs, and only serve the purpose of
resolving visibility so LTO can better optimize. Running LTO creates ObjFiles
from BitcodeFiles, and those ObjFiles contain regular Defined symbols (with
isec set and all) that will replace the bitcode symbols. So things should
(hopefully) work as-is :)"""

  -- https://reviews.llvm.org/rGdbbc8d8333f29cf4ad6f4793da1adf71bbfdac69#inline-6081
This commit is contained in:
Nico Weber 2021-06-23 16:24:41 -04:00
parent 2716c6faa4
commit ef75358080
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lld/MachO/UnwindInfoSection.cpp
View File

@ -297,8 +297,6 @@ static void addEntriesForFunctionsWithoutUnwindInfo(
// Add explicit "has no unwind info" entries for all global and local symbols
// without unwind info.
auto markNoUnwindInfo = [&cuVector, &hasUnwindInfo](const Defined *d) {
// FIXME: The d->isec null check might be incorrect for symbols
// from LTO files.
if (d->isLive() && d->isec && isCodeSection(d->isec)) {
Ptr ptr = d->getVA();
if (!hasUnwindInfo.count(ptr))