maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

de-flake TestThreadStates.test_process_interrupt 

the "self.assertEqual(thread.GetStopReason(), lldb.eStopReasonSignal)"
was occasionally failing because the stop reason would come out as
"trace" this happened if we issued the interrupt just as the processed
stopped due to single-stepping over the breakpoint (i.e., the it was not
necessary to send any signal).

Fix this by removing the breakpoint before resuming the process. This
ensures the process can run unobstructed.

After this, the test passed 200 consecutive runs successfully for me,
even while the system was under heavy load.

llvm-svn: 349491
This commit is contained in:
Pavel Labath 2018-12-18 15:15:02 +00:00
parent 1164dab2bc
commit ef4d4f543a
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
View File

@ -199,7 +199,7 @@ class ThreadStateTestCase(TestBase):
self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
# This should create a breakpoint in the main thread. # This should create a breakpoint in the main thread.
lldbutil.run_break_set_by_file_and_line( bpno = lldbutil.run_break_set_by_file_and_line(
self, "main.cpp", self.break_1, num_expected_locations=1) self, "main.cpp", self.break_1, num_expected_locations=1)
# Run the program. # Run the program.
@ -213,6 +213,10 @@ class ThreadStateTestCase(TestBase):
process, lldb.eStopReasonBreakpoint) process, lldb.eStopReasonBreakpoint)
self.assertIsNotNone(thread) self.assertIsNotNone(thread)
# Remove the breakpoint to avoid the single-step-over-bkpt dance in the
# "continue" below
self.assertTrue(target.BreakpointDelete(bpno))
# Continue, the inferior will go into an infinite loop waiting for # Continue, the inferior will go into an infinite loop waiting for
# 'g_test' to change. # 'g_test' to change.
self.dbg.SetAsync(True) self.dbg.SetAsync(True)