maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Return false from __has_declspec_attribute() if not explicitly enabled 

Currently, projects can check for __has_declspec_attribute() and use
it accordingly, but the check for __has_declspec_attribute will return
true even if declspec attributes are not enabled for the target.

This changes Clang to instead return false when declspec attributes are
not supported for the target.
This commit is contained in:
Timm Bäder 2021-01-12 13:18:13 -05:00 committed by Aaron Ballman
parent b117d17d26
commit ef3800e821
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang/lib/Lex/PPMacroExpansion.cpp
View File

@ -1693,8 +1693,14 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) {
[this](Token &Tok, bool &HasLexedNextToken) -> int {
IdentifierInfo *II = ExpectFeatureIdentifierInfo(Tok, *this,
diag::err_feature_check_malformed);
return II ? hasAttribute(AttrSyntax::Declspec, nullptr, II,
getTargetInfo(), getLangOpts()) : 0;
if (II) {
const LangOptions &LangOpts = getLangOpts();
return LangOpts.DeclSpecKeyword &&
hasAttribute(AttrSyntax::Declspec, nullptr, II,
getTargetInfo(), LangOpts);
}
return false;
});
} else if (II == Ident__has_cpp_attribute ||
II == Ident__has_c_attribute) {