maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Don't create a MemoryBuffer just to get the MemoryBufferRef. NFC. 

llvm-svn: 216608
This commit is contained in:
Rafael Espindola 2014-08-27 20:25:55 +00:00
parent 4e82ec9caa
commit eeec8e63c0
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/tools/gold/gold-plugin.cpp
View File

@ -269,15 +269,15 @@ static const GlobalObject *getBaseObject(const GlobalValue &GV) {
static ld_plugin_status claim_file_hook(const ld_plugin_input_file *file,
int *claimed) {
LLVMContext Context;
std::unique_ptr<MemoryBuffer> buffer;
MemoryBufferRef BufferRef;
std::unique_ptr<MemoryBuffer> Buffer;
if (get_view) {
const void *view;
if (get_view(file->handle, &view) != LDPS_OK) {
message(LDPL_ERROR, "Failed to get a view of %s", file->name);
return LDPS_ERR;
}
buffer = MemoryBuffer::getMemBuffer(StringRef((char *)view, file->filesize),
"", false);
BufferRef = MemoryBufferRef(StringRef((char *)view, file->filesize), "");
} else {
int64_t offset = 0;
// Gold has found what might be IR part-way inside of a file, such as
@ -292,12 +292,12 @@ static ld_plugin_status claim_file_hook(const ld_plugin_input_file *file,
message(LDPL_ERROR, EC.message().c_str());
return LDPS_ERR;
}
buffer = std::move(BufferOrErr.get());
Buffer = std::move(BufferOrErr.get());
BufferRef = Buffer->getMemBufferRef();
}
ErrorOr<object::IRObjectFile *> ObjOrErr =
object::IRObjectFile::createIRObjectFile(buffer->getMemBufferRef(),
Context);
object::IRObjectFile::createIRObjectFile(BufferRef, Context);
std::error_code EC = ObjOrErr.getError();
if (EC == BitcodeError::InvalidBitcodeSignature)
return LDPS_OK;