maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments 

Reviewers: alexfh, aaron.ballman, hokein

Reviewed By: alexfh

Subscribers: xazax.hun, cfe-commits

Differential Revision: https://reviews.llvm.org/D52688

llvm-svn: 343792
This commit is contained in:
Jonas Toth 2018-10-04 15:59:30 +00:00
parent 28a4c0ff3b
commit ee2fcdf5b7
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
clang-tools-extra/test/clang-tidy/fuchsia-default-arguments.cpp
View File

@ -1,14 +1,13 @@
// RUN: %check_clang_tidy %s fuchsia-default-arguments %t
int foo(int value = 5) { return value; }
// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-FIXES: int foo(int value) { return value; }
int f() {
foo();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NEXT: note: default parameter was declared here:
// CHECK-NEXT: int foo(int value = 5) { return value; }
// CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-8]]:9: note: default parameter was declared here
}
int bar(int value) { return value; }
@ -21,7 +20,7 @@ int n() {
class Baz {
public:
int a(int value = 5) { return value; }
// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-FIXES: int a(int value) { return value; }
int b(int value) { return value; }
@ -30,7 +29,7 @@ public:
class Foo {
// Fix should be suggested in declaration
int a(int value = 53);
// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-FIXES: int a(int value);
};
@ -41,7 +40,7 @@ int Foo::a(int value) {
// Elided functions
void f(int = 5) {};
// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-FIXES: void f(int) {};
void g(int) {};
@ -50,12 +49,12 @@ void g(int) {};
#define D(val) = val
void h(int i D(5));
// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-FIXES-NOT: void h(int i);
void x(int i);
void x(int i = 12);
// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-FIXES: void x(int i);
void x(int i) {}
@ -65,17 +64,17 @@ struct S {
};
void S::x(int i = 12) {}
// CHECK-MESSAGES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments]
// CHECK-FIXES: void S::x(int i) {}
int main() {
S s;
s.x();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NEXT: note: default parameter was declared here:
// CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-9]]:11: note: default parameter was declared here
// CHECK-NEXT: void S::x(int i = 12) {}
x();
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NEXT: note: default parameter was declared here:
// CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments]
// CHECK-NOTES: [[@LINE-19]]:8: note: default parameter was declared here
// CHECK-NEXT: void x(int i = 12);
}