Revert r53282. This was causing a miscompile on Linux. Also, the transformation

looks bogus. Please see PR2629 for details on why this is breaking things.

llvm-svn: 54372
This commit is contained in:
Bill Wendling 2008-08-05 21:23:45 +00:00
parent d9b88a85f2
commit ee12a7aeff
2 changed files with 0 additions and 26 deletions

View File

@ -3586,22 +3586,6 @@ Instruction *InstCombiner::visitAnd(BinaryOperator &I) {
}
}
{ // (icmp ugt/ult A, C) & (icmp B, C) --> (icmp (A|B), C)
// where C is a power of 2
Value *A, *B;
ConstantInt *C1, *C2;
ICmpInst::Predicate LHSCC, RHSCC;
if (match(&I, m_And(m_ICmp(LHSCC, m_Value(A), m_ConstantInt(C1)),
m_ICmp(RHSCC, m_Value(B), m_ConstantInt(C2)))))
if (C1 == C2 && LHSCC == RHSCC && C1->getValue().isPowerOf2() &&
(LHSCC == ICmpInst::ICMP_ULT || LHSCC == ICmpInst::ICMP_UGT)) {
Instruction *NewOr = BinaryOperator::CreateOr(A, B);
InsertNewInstBefore(NewOr, I);
return new ICmpInst(LHSCC, NewOr, C1);
}
}
if (ICmpInst *RHS = dyn_cast<ICmpInst>(Op1)) {
// (icmp1 A, B) & (icmp2 A, B) --> (icmp3 A, B)
if (Instruction *R = AssociativeOpt(I, FoldICmpLogical(*this, RHS)))

View File

@ -1,10 +0,0 @@
; RUN: llvm-as < %s | opt -instcombine | llvm-dis | grep icmp | count 1
; PR2330
define i1 @foo(i32 %a, i32 %b) nounwind {
entry:
icmp ult i32 %a, 8 ; <i1>:0 [#uses=1]
icmp ult i32 %b, 8 ; <i1>:1 [#uses=1]
and i1 %1, %0 ; <i1>:2 [#uses=1]
ret i1 %2
}