maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[CMake] Update C4324 MSVC warning comment to explain its still broken at VS2019 

As promised, I've updated the comment for the C4324 MSVC warning that was re-disabled at rL367409 / rG8f823e63e3edf87ab029ba32b68f3eb5d2f392b5 to put it in terms of currently supported VS versions

llvm-svn: 369368
This commit is contained in:
Simon Pilgrim 2019-08-20 11:20:05 +00:00
parent 6a3dc3e15c
commit ed72e0ecf8
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/cmake/modules/HandleLLVMOptions.cmake
View File

@ -543,12 +543,10 @@ if (MSVC)
# is fixed. # is fixed.
-wd4709 # Suppress comma operator within array index expression -wd4709 # Suppress comma operator within array index expression
# Ideally, we'd like this warning to be enabled, but MSVC 2013 doesn't # Ideally, we'd like this warning to be enabled, but even MSVC 2019 doesn't
# support the 'aligned' attribute in the way that clang sources requires (for # support the 'aligned' attribute in the way that clang sources requires (for
# any code that uses the LLVM_ALIGNAS macro), so this is must be disabled to # any code that uses the LLVM_ALIGNAS macro), so this is must be disabled to
# avoid unwanted alignment warnings. # avoid unwanted alignment warnings.
# When we switch to requiring a version of MSVC that supports the 'alignas'
# specifier (MSVC 2015?) this warning can be re-enabled.
-wd4324 # Suppress 'structure was padded due to __declspec(align())' -wd4324 # Suppress 'structure was padded due to __declspec(align())'
# Promoted warnings. # Promoted warnings.