maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Better support for scalar POD types in 'new' expressions. 

llvm-svn: 72674
This commit is contained in:
Anders Carlsson 2009-05-31 20:56:36 +00:00
parent 6f9dabff6d
commit ec71f61608
2 changed files with 24 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
clang/lib/CodeGen/CGCXX.cpp
View File

@ -285,20 +285,29 @@ llvm::Value *CodeGenFunction::EmitCXXNewExpr(const CXXNewExpr *E) {
CGM.GetAddrOfFunction(GlobalDecl(NewFD)), CGM.GetAddrOfFunction(GlobalDecl(NewFD)),
NewArgs, NewFD); NewArgs, NewFD);
llvm::Value *V = Builder.CreateBitCast(RV.getScalarVal(), llvm::Value *NewPtr = Builder.CreateBitCast(RV.getScalarVal(),
ConvertType(E->getType())); ConvertType(E->getType()));
if (E->hasInitializer()) { if (AllocType->isPODType()) {
ErrorUnsupported(E, "new expression with initializer"); if (E->getNumConstructorArgs() != 0) {
return llvm::UndefValue::get(ConvertType(E->getType())); assert(E->getNumConstructorArgs() == 1 &&
"Can only have one argument to initializer of POD type.");
const Expr *Init = E->getConstructorArg(0);
if (!hasAggregateLLVMType(AllocType)) {
Builder.CreateStore(EmitScalarExpr(Init), NewPtr);
} else {
ErrorUnsupported(E, "new expression");
return llvm::UndefValue::get(ConvertType(E->getType()));
}
}
return NewPtr;
} }
if (!AllocType->isPODType()) { ErrorUnsupported(E, "new expression with non-POD type");
ErrorUnsupported(E, "new expression with non-POD type"); return llvm::UndefValue::get(ConvertType(E->getType()));
return llvm::UndefValue::get(ConvertType(E->getType()));
}
return V;
} }
static bool canGenerateCXXstructor(const CXXRecordDecl *RD, static bool canGenerateCXXstructor(const CXXRecordDecl *RD,

4
clang/test/CodeGenCXX/new.cpp
View File

@ -10,3 +10,7 @@ void* operator new(unsigned long, void*) throw();
void t2(int* a) { void t2(int* a) {
int* b = new (a) int; int* b = new (a) int;
} }
void t3() {
int *a = new int(10);
}