From ebee45713190d9844ef860bf491035e3dcf3a538 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Wed, 14 Apr 2021 16:25:23 -0700 Subject: [PATCH] [LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash reports We have seen several crashes in LibCppStdFunctionCallableInfo(...) but we don't have a reproducer. The last crash pointed to last call to line_entry_helper(...) and symbol was a nullptr. So adding a check for this case. --- .../Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp b/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp index 02d9bff9eee3..ff2c064ee388 100644 --- a/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp +++ b/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp @@ -322,6 +322,9 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo( } } + if (symbol == nullptr) + return optional_info; + // Case 1 or 3 if (scl.GetSize() >= 1) { optional_info = line_entry_helper(target, scl[0], symbol,