maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[llvm-objcopy] Append '\n' to warning messages 

Currently the warning message of `llvm-strip %t.o %t.o` does not include
the trailing newline. Fix this by appending a '\n'.

This is the only warning llvm-objcopy and llvm-strip can issue.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D66475

llvm-svn: 369391
This commit is contained in:
Fangrui Song 2019-08-20 15:00:07 +00:00
parent a90ee0eeb6
commit ebd50291e8
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/test/tools/llvm-objcopy/ELF/same-file-strip.test
View File

@ -9,10 +9,11 @@
# ERR: error: cannot specify '-' as an input file more than once
# RUN: llvm-strip %t %t 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t
# RUN: llvm-strip %t %t %t 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t
# RUN: cp %t %t2
# RUN: llvm-strip %t %t %t %t2 %t2 2>&1 | FileCheck -check-prefix=WARN %s -DFILE=%t -DFILE2=%t2
# WARN: warning: '[[FILE]]' was already specified
# WARN: warning: '[[FILE]]' was already specified
# WARN-NEXT: warning: '[[FILE2]]' was already specified
--- !ELF
FileHeader:

2
llvm/tools/llvm-objcopy/llvm-objcopy.cpp
View File

@ -84,7 +84,7 @@ LLVM_ATTRIBUTE_NORETURN void reportError(StringRef File, Error E) {
ErrorSuccess reportWarning(Error E) {
assert(E);
WithColor::warning(errs(), ToolName) << toString(std::move(E));
WithColor::warning(errs(), ToolName) << toString(std::move(E)) << '\n';
return Error::success();
}