maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[MLIR][Presburger] subtraction: add support for divs defined by equalties 

Reviewed By: Groverkss

Differential Revision: https://reviews.llvm.org/D124668
This commit is contained in:
Arjun P 2022-04-29 12:37:13 +01:00
parent d563df88e9
commit ebbfe0136e
2 changed files with 27 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
mlir/lib/Analysis/Presburger/PresburgerRelation.cpp
View File

@ -236,21 +236,33 @@ static PresburgerRelation getSetDifference(IntegerRelation b,
// such inequalities to b.
llvm::SmallBitVector canIgnoreIneq(sI.getNumInequalities() +
2 * sI.getNumEqualities());
for (MaybeLocalRepr &maybeInequality : repr) {
for (MaybeLocalRepr &maybeRepr : repr) {
assert(
maybeInequality.kind == ReprKind::Inequality &&
maybeRepr &&
"Subtraction is not supported when a representation of the local "
"variables of the subtrahend cannot be found!");
unsigned lb = maybeInequality.repr.inequalityPair.lowerBoundIdx;
unsigned ub = maybeInequality.repr.inequalityPair.upperBoundIdx;
b.addInequality(sI.getInequality(lb));
b.addInequality(sI.getInequality(ub));
if (maybeRepr.kind == ReprKind::Inequality) {
unsigned lb = maybeRepr.repr.inequalityPair.lowerBoundIdx;
unsigned ub = maybeRepr.repr.inequalityPair.upperBoundIdx;
assert(lb != ub &&
"Upper and lower bounds must be different inequalities!");
canIgnoreIneq[lb] = true;
canIgnoreIneq[ub] = true;
b.addInequality(sI.getInequality(lb));
b.addInequality(sI.getInequality(ub));
assert(lb != ub &&
"Upper and lower bounds must be different inequalities!");
canIgnoreIneq[lb] = true;
canIgnoreIneq[ub] = true;
} else {
assert(maybeRepr.kind == ReprKind::Equality &&
"ReprKind isn't inequality so should be equality");
unsigned idx = maybeRepr.repr.equalityIdx;
b.addEquality(sI.getEquality(idx));
// We can ignore both inequalities corresponding to this equality.
unsigned offset = sI.getNumInequalities();
canIgnoreIneq[offset + 2 * idx] = true;
canIgnoreIneq[offset + 2 * idx + 1] = true;
}
}
unsigned offset = simplex.getNumConstraints();

5
mlir/unittests/Analysis/Presburger/PresburgerSetTest.cpp
View File

@ -455,6 +455,11 @@ TEST(SetTest, divisions) {
PresburgerSet setA{parsePoly("(x) : (-x >= 0)")};
PresburgerSet setB{parsePoly("(x) : (x floordiv 2 - 4 >= 0)")};
EXPECT_TRUE(setA.subtract(setB).isEqual(setA));
IntegerPolyhedron evensDefByEquality(PresburgerSpace::getSetSpace(
/*numDims=*/1, /*numSymbols=*/0, /*numLocals=*/1));
evensDefByEquality.addEquality({1, -2, 0});
expectEqual(evens, PresburgerSet(evensDefByEquality));
}
TEST(SetTest, subtractDuplicateDivsRegression) {