diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp index dbf41f38b8f8..260fa5b52919 100644 --- a/clang/lib/CodeGen/CGExpr.cpp +++ b/clang/lib/CodeGen/CGExpr.cpp @@ -2786,10 +2786,21 @@ RValue CodeGenFunction::EmitAtomicExpr(AtomicExpr *E, llvm::Value *Dest) { if (E->getOp() == AtomicExpr::Init) { assert(!Dest && "Init does not return a value"); - Val1 = EmitScalarExpr(E->getVal1()); - llvm::StoreInst *Store = Builder.CreateStore(Val1, Ptr); - Store->setAlignment(Size); - Store->setVolatile(E->isVolatile()); + if (!hasAggregateLLVMType(E->getVal1()->getType())) { + llvm::StoreInst *Store = + Builder.CreateStore(EmitScalarExpr(E->getVal1()), Ptr); + Store->setAlignment(Size); + Store->setVolatile(E->isVolatile()); + } else if (E->getType()->isAnyComplexType()) { + EmitComplexExprIntoAddr(E->getVal1(), Ptr, E->isVolatile()); + } else { + AggValueSlot Slot = AggValueSlot::forAddr(Ptr, alignChars, + AtomicTy.getQualifiers(), + AggValueSlot::IsNotDestructed, + AggValueSlot::DoesNotNeedGCBarriers, + AggValueSlot::IsNotAliased); + EmitAggExpr(E->getVal1(), Slot); + } return RValue::get(0); } diff --git a/clang/test/CodeGenCXX/atomicinit.cpp b/clang/test/CodeGenCXX/atomicinit.cpp index 17c5b62a3acf..63e38118fe15 100644 --- a/clang/test/CodeGenCXX/atomicinit.cpp +++ b/clang/test/CodeGenCXX/atomicinit.cpp @@ -10,3 +10,16 @@ void A::v(int j) { i = j; } // Initialising atomic values should not be atomic // CHECK-NOT: store atomic A::A(int j) : i(j) {} + +struct B { + int i; + B(int x) : i(x) {} +}; + +_Atomic(B) b; + +// CHECK: define void @_Z11atomic_initR1Ai +void atomic_init(A& a, int i) { + // CHECK-NOT: atomic + __atomic_init(&b, B(i)); +}