From eb6782758a54f200a1a5e531bef28192833d2584 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Wed, 24 Jul 2019 22:12:02 +0000 Subject: [PATCH] [Symbol] Fix some botched logic in Variable::GetLanguage Summary: I messed up the logic for this. Fixing with some improvements suggested by Pavel. Reviewers: labath, jdoerfert Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D65165 llvm-svn: 366950 --- lldb/source/Symbol/Variable.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lldb/source/Symbol/Variable.cpp b/lldb/source/Symbol/Variable.cpp index d86401178d5d..5cc03d7809f5 100644 --- a/lldb/source/Symbol/Variable.cpp +++ b/lldb/source/Symbol/Variable.cpp @@ -59,12 +59,12 @@ lldb::LanguageType Variable::GetLanguage() const { return lang; if (auto *func = m_owner_scope->CalculateSymbolContextFunction()) { - if ((lang = func->GetLanguage()) && lang != lldb::eLanguageTypeUnknown) + if ((lang = func->GetLanguage()) != lldb::eLanguageTypeUnknown) + return lang; + } else if (auto *comp_unit = + m_owner_scope->CalculateSymbolContextCompileUnit()) { + if ((lang = comp_unit->GetLanguage()) != lldb::eLanguageTypeUnknown) return lang; - else if (auto *comp_unit = - m_owner_scope->CalculateSymbolContextCompileUnit()) - if ((lang = func->GetLanguage()) && lang != lldb::eLanguageTypeUnknown) - return lang; } return lldb::eLanguageTypeUnknown;