From ea350180d2560ae338dacfeb454910fefcecf291 Mon Sep 17 00:00:00 2001 From: Kaelyn Uhrain Date: Thu, 4 Aug 2011 23:30:54 +0000 Subject: [PATCH] Fix a small bug where DiagnoseEmptyLookup would no longer print any messages when performing typo correction involving any overloaded template functions. The added test cases, while currently demontrating sub-optimal behavior, will not trigger any messages without the 1-line change to SemaExpr.cpp. llvm-svn: 136943 --- clang/lib/Sema/SemaExpr.cpp | 3 +-- .../SemaCXX/function-overload-typo-crash.cpp | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 6ace3e92e600..ffa092aad1ea 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -1468,8 +1468,7 @@ bool Sema::DiagnoseEmptyLookup(Scope *S, CXXScopeSpec &SS, LookupResult &R, ND = Best->Function; break; default: - // Don't try to recover; it won't work. - return true; + break; } } R.addDecl(ND); diff --git a/clang/test/SemaCXX/function-overload-typo-crash.cpp b/clang/test/SemaCXX/function-overload-typo-crash.cpp index 580f27a12afd..a0f70dfbdb9c 100644 --- a/clang/test/SemaCXX/function-overload-typo-crash.cpp +++ b/clang/test/SemaCXX/function-overload-typo-crash.cpp @@ -10,3 +10,22 @@ void f() { fin(); //expected-error {{use of undeclared identifier 'fin'; did you mean 'min'}} fax(0); //expected-error {{use of undeclared identifier 'fax'; did you mean 'max'}} } + +// TODO: Add proper function overloading resolution for template functions +template void somefunc(T*, T*); +template void somefunc(const T[]); +template void somefunc(T1*, T2*); +template void somefunc(T1*, const T2[]); //expected-note 5 {{'somefunc' declared here}} \ + //expected-note {{candidate function template not viable: requires 2 arguments, but 1 was provided}} TODO this shouldn't happen + +void c() { + int *i = 0, *j = 0; + const int x[] = {1, 2, 3}; + long *l = 0; + somefun(i, j); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}} + somefun(x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}} \ + //expected-error {{no matching function for call to 'somefunc'}} TODO this shouldn't happen + somefun(i, l); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}} + somefun(l, x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}} + somefun(i, x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}} +}