maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix a small bug where DiagnoseEmptyLookup would no longer print any messages 

when performing typo correction involving any overloaded template functions.

The added test cases, while currently demontrating sub-optimal behavior, will
not trigger any messages without the 1-line change to SemaExpr.cpp.

llvm-svn: 136943
This commit is contained in:
Kaelyn Uhrain 2011-08-04 23:30:54 +00:00
parent 08d4bb0f12
commit ea350180d2
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/lib/Sema/SemaExpr.cpp
View File

@ -1468,8 +1468,7 @@ bool Sema::DiagnoseEmptyLookup(Scope *S, CXXScopeSpec &SS, LookupResult &R,
ND = Best->Function;
break;
default:
// Don't try to recover; it won't work.
return true;
break;
}
}
R.addDecl(ND);

19
clang/test/SemaCXX/function-overload-typo-crash.cpp
View File

@ -10,3 +10,22 @@ void f() {
fin(); //expected-error {{use of undeclared identifier 'fin'; did you mean 'min'}}
fax(0); //expected-error {{use of undeclared identifier 'fax'; did you mean 'max'}}
}
// TODO: Add proper function overloading resolution for template functions
template <typename T> void somefunc(T*, T*);
template <typename T> void somefunc(const T[]);
template <typename T1, typename T2> void somefunc(T1*, T2*);
template <typename T1, typename T2> void somefunc(T1*, const T2[]); //expected-note 5 {{'somefunc' declared here}} \
//expected-note {{candidate function template not viable: requires 2 arguments, but 1 was provided}} TODO this shouldn't happen
void c() {
int *i = 0, *j = 0;
const int x[] = {1, 2, 3};
long *l = 0;
somefun(i, j); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}}
somefun(x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}} \
//expected-error {{no matching function for call to 'somefunc'}} TODO this shouldn't happen
somefun(i, l); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}}
somefun(l, x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}}
somefun(i, x); //expected-error {{use of undeclared identifier 'somefun'; did you mean 'somefunc'?}}
}