maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

BPF: fix a bug in IRPeephole pass 

Commit 009f3a89d8 ("BPF: remove intrindics @llvm.stacksave()
and @llvm.stackrestore()") implemented IRPeephole pass to remove
llvm.stacksave()/stackrestore() instrinsics.
Buildbot reported a failure:
  UNREACHABLE executed at ../lib/IR/LegacyPassManager.cpp:1445!
which is:
  llvm_unreachable("Pass modifies its input and doesn't report it");

The code has changed but the implementation didn't return true
for changing. This patch fixed this problem.
This commit is contained in:
Yonghong Song 2021-10-18 10:13:53 -07:00
parent 2e4e2004af
commit e9e4fc0fd3
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/Target/BPF/BPFIRPeephole.cpp
View File

@ -30,6 +30,7 @@ namespace {
static bool BPFIRPeepholeImpl(Function &F) {
LLVM_DEBUG(dbgs() << "******** BPF IR Peephole ********\n");
bool Changed = false;
Instruction *ToErase = nullptr;
for (auto &BB : F) {
for (auto &I : BB) {
@ -64,6 +65,7 @@ static bool BPFIRPeepholeImpl(Function &F) {
auto *Inst = cast<Instruction>(*Call->user_begin());
LLVM_DEBUG(dbgs() << "Remove:"; I.dump());
LLVM_DEBUG(dbgs() << "Remove:"; Inst->dump(); dbgs() << '\n');
Changed = true;
Inst->eraseFromParent();
ToErase = &I;
}
@ -83,13 +85,14 @@ static bool BPFIRPeepholeImpl(Function &F) {
continue;
LLVM_DEBUG(dbgs() << "Remove:"; I.dump());
LLVM_DEBUG(dbgs() << "Remove:"; Call->dump(); dbgs() << '\n');
Changed = true;
Call->eraseFromParent();
ToErase = &I;
}
}
}
return false;
return Changed;
}
class BPFIRPeephole final : public FunctionPass {