maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4 

This is an addendum to r229921.

llvm-svn: 267625
This commit is contained in:
Sunil Srivastava 2016-04-26 23:19:00 +00:00
parent 29dea0d230
commit e9e3631aba
2 changed files with 10 additions and 3 deletions

4
clang/lib/Analysis/FormatString.cpp
View File

@ -694,7 +694,7 @@ bool FormatSpecifier::hasValidLengthModifier(const TargetInfo &Target) const {
return true;
case ConversionSpecifier::FreeBSDrArg:
case ConversionSpecifier::FreeBSDyArg:
return Target.getTriple().isOSFreeBSD();
return Target.getTriple().isOSFreeBSD() || Target.getTriple().isPS4();
default:
return false;
}
@ -727,7 +727,7 @@ bool FormatSpecifier::hasValidLengthModifier(const TargetInfo &Target) const {
return true;
case ConversionSpecifier::FreeBSDrArg:
case ConversionSpecifier::FreeBSDyArg:
return Target.getTriple().isOSFreeBSD();
return Target.getTriple().isOSFreeBSD() || Target.getTriple().isPS4();
default:
return false;
}

9
clang/test/Sema/format-strings-freebsd.c
View File

@ -1,10 +1,11 @@
// RUN: %clang_cc1 -fsyntax-only -verify -triple i386-unknown-freebsd %s
// RUN: %clang_cc1 -fsyntax-only -verify -triple x86_64-unknown-freebsd %s
// RUN: %clang_cc1 -fsyntax-only -verify -triple x86_64-scei-ps4 %s
// Test FreeBSD kernel printf extensions.
int freebsd_kernel_printf(const char *, ...) __attribute__((__format__(__freebsd_kprintf__, 1, 2)));
void check_freebsd_kernel_extensions(int i, long l, char *s)
void check_freebsd_kernel_extensions(int i, long l, char *s, short h)
{
// %b expects an int and a char *
freebsd_kernel_printf("reg=%b\n", i, "\10\2BITTWO\1BITONE\n"); // no-warning
@ -32,6 +33,12 @@ void check_freebsd_kernel_extensions(int i, long l, char *s)
freebsd_kernel_printf("%lr", i); // expected-warning{{format specifies type 'long' but the argument has type 'int'}}
freebsd_kernel_printf("%lr", l); // no-warning
// h modifier expects a short
freebsd_kernel_printf("%hr", i); // expected-warning{{format specifies type 'short' but the argument has type 'int'}}
freebsd_kernel_printf("%hr", h); // no-warning
freebsd_kernel_printf("%hy", i); // expected-warning{{format specifies type 'short' but the argument has type 'int'}}
freebsd_kernel_printf("%hy", h); // no-warning
// %y expects an int
freebsd_kernel_printf("%y", i); // no-warning
freebsd_kernel_printf("%y", l); // expected-warning{{format specifies type 'int' but the argument has type 'long'}}