Check the specific target to figure out if a constraint is a valid

register constraint. Note that we're not checking if the register itself
is valid for the constraint.

Fixes rdar://9382985

llvm-svn: 133226
This commit is contained in:
Eric Christopher 2011-06-17 01:53:34 +00:00
parent d10485412d
commit e9544258ef
2 changed files with 31 additions and 2 deletions

View File

@ -1278,8 +1278,11 @@ AddVariableConstraints(const std::string &Constraint, const Expr &AsmExpr,
return Constraint;
llvm::StringRef Register = Attr->getLabel();
assert(Target.isValidGCCRegisterName(Register));
// FIXME: We should check which registers are compatible with "r" or "x".
if (Constraint != "r" && Constraint != "x") {
// We're using validateOutputConstraint here because we only care if
// this is a register constraint.
TargetInfo::ConstraintInfo Info(Constraint, "");
if (Target.validateOutputConstraint(Info) &&
!Info.allowsRegister()) {
CGM.ErrorUnsupported(&Stmt, "__asm__");
return Constraint;
}

View File

@ -0,0 +1,26 @@
// RUN: %clang_cc1 -triple armv7-apple-darwin9 -emit-llvm -w -o - %s | FileCheck %s
#include <stdint.h>
#define ldrex_func(p, rl, rh) \
__asm__ __volatile__( \
"ldrexd%[_rl], %[_rh], [%[_p]]" \
: [_rl] "=&r" (rl), [_rh] "=&r" (rh) \
: [_p] "p" (p) : "memory")
int64_t foo(int64_t v, volatile int64_t *p)
{
register uint32_t rl asm("r1");
register uint32_t rh asm("r2");
int64_t r;
uint32_t t;
__asm__ __volatile__( \
"ldrexd%[_rl], %[_rh], [%[_p]]" \
: [_rl] "=&r" (rl), [_rh] "=&r" (rh) \
: [_p] "p" (p) : "memory");
// CHECK: %0 = call %0 asm sideeffect "ldrexd$0, $1, [$2]", "={r1},={r2},r,~{memory}"(i64* %tmp)
return r;
}