maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert "[X86] Add back the assert in getImpliedFeatures that I removed in ef4cc70f3ed2a91e0a48c6448c517c3ba34c2846" 

This reverts commit 91f70675cc.
It seems to break most (all?) hwasan tests.
This commit is contained in:
Nico Weber 2020-07-07 22:56:08 -04:00
parent 0a41493b98
commit e885f336fd
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
llvm/include/llvm/Support/X86TargetParser.def
View File

@ -226,6 +226,5 @@ X86_FEATURE (RETPOLINE_INDIRECT_BRANCHES, "retpoline-indirect-branches")
X86_FEATURE (RETPOLINE_INDIRECT_CALLS, "retpoline-indirect-calls")
X86_FEATURE (LVI_CFI, "lvi-cfi")
X86_FEATURE (LVI_LOAD_HARDENING, "lvi-load-hardening")
X86_FEATURE (SESES, "seses")
#undef X86_FEATURE_COMPAT
#undef X86_FEATURE

2
llvm/lib/Support/X86TargetParser.cpp
View File

@ -446,7 +446,6 @@ static constexpr FeatureBitset ImpliedFeaturesRETPOLINE_INDIRECT_BRANCHES = {};
static constexpr FeatureBitset ImpliedFeaturesRETPOLINE_INDIRECT_CALLS = {};
static constexpr FeatureBitset ImpliedFeaturesLVI_CFI = {};
static constexpr FeatureBitset ImpliedFeaturesLVI_LOAD_HARDENING = {};
static constexpr FeatureBitset ImpliedFeaturesSESES = {};
// XSAVE features are dependent on basic XSAVE.
static constexpr FeatureBitset ImpliedFeaturesXSAVEC = FeatureXSAVE;
@ -574,7 +573,6 @@ void llvm::X86::getImpliedFeatures(
if (I == std::end(FeatureInfos)) {
// FIXME: This shouldn't happen, but may not have all features in the table
// yet.
assert(false && "Feature not found in table!");
return;
}