maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix stack-use-after free after r359580 

`Candidate` was a StringRef refering to a temporary string.
Instead, create a local variable for the string and use
a StringRef referring to that.

llvm-svn: 359604
This commit is contained in:
Nico Weber 2019-04-30 19:43:35 +00:00
parent b4989294c8
commit e7fa09e4ae
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/Option/OptTable.cpp
View File

@ -296,9 +296,10 @@ unsigned OptTable::findNearest(StringRef Option, std::string &NearestString,
// "--help" over "-help".
for (int P = 0; const char *const CandidatePrefix = CandidateInfo.Prefixes[P]; P++) {
std::string NormalizedName = (LHS + Delimiter).str();
StringRef Candidate = (CandidatePrefix + CandidateName).str();
std::string Candidate = (CandidatePrefix + CandidateName).str();
StringRef CandidateRef = Candidate;
unsigned Distance =
Candidate.edit_distance(NormalizedName, /*AllowReplacements=*/true,
CandidateRef.edit_distance(NormalizedName, /*AllowReplacements=*/true,
/*MaxEditDistance=*/BestDistance);
if (Distance < BestDistance) {
BestDistance = Distance;