From e77c8425e168aa93968c47689e2bf976fc46a2d2 Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Sat, 18 Nov 2017 00:54:31 +0000 Subject: [PATCH] [ABI] Remove dead code that was copy-pasted all around. NFCI. llvm-svn: 318580 --- .../Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp | 41 ------------------- .../Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp | 41 ------------------- 2 files changed, 82 deletions(-) diff --git a/lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp b/lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp index 06a8ce932fda..2fee176739f3 100644 --- a/lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp +++ b/lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp @@ -291,47 +291,6 @@ bool ABISysV_ppc::PrepareTrivialCall(Thread &thread, addr_t sp, RegisterValue reg_value; -#if 0 - // This code adds an extra frame so that we don't lose the function that we came from - // by pushing the PC and the FP and then writing the current FP to point to the FP value - // we just pushed. It is disabled for now until the stack backtracing code can be debugged. - - // Save current PC - const RegisterInfo *fp_reg_info = reg_ctx->GetRegisterInfo (eRegisterKindGeneric, LLDB_REGNUM_GENERIC_FP); - if (reg_ctx->ReadRegister(pc_reg_info, reg_value)) - { - if (log) - log->Printf("Pushing the current PC onto the stack: 0x%" PRIx64 ": 0x%" PRIx64, (uint64_t)sp, reg_value.GetAsUInt64()); - - if (!process_sp->WritePointerToMemory(sp, reg_value.GetAsUInt64(), error)) - return false; - - sp -= 8; - - // Save current FP - if (reg_ctx->ReadRegister(fp_reg_info, reg_value)) - { - if (log) - log->Printf("Pushing the current FP onto the stack: 0x%" PRIx64 ": 0x%" PRIx64, (uint64_t)sp, reg_value.GetAsUInt64()); - - if (!process_sp->WritePointerToMemory(sp, reg_value.GetAsUInt64(), error)) - return false; - } - // Setup FP backchain - reg_value.SetUInt64 (sp); - - if (log) - log->Printf("Writing FP: 0x%" PRIx64 " (for FP backchain)", reg_value.GetAsUInt64()); - - if (!reg_ctx->WriteRegister(fp_reg_info, reg_value)) - { - return false; - } - - sp -= 8; - } -#endif - if (log) log->Printf("Pushing the return address onto the stack: 0x%" PRIx64 ": 0x%" PRIx64, diff --git a/lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp b/lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp index c090f01ccb1c..0348853c7fa0 100644 --- a/lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp +++ b/lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp @@ -291,47 +291,6 @@ bool ABISysV_ppc64::PrepareTrivialCall(Thread &thread, addr_t sp, RegisterValue reg_value; -#if 0 - // This code adds an extra frame so that we don't lose the function that we came from - // by pushing the PC and the FP and then writing the current FP to point to the FP value - // we just pushed. It is disabled for now until the stack backtracing code can be debugged. - - // Save current PC - const RegisterInfo *fp_reg_info = reg_ctx->GetRegisterInfo (eRegisterKindGeneric, LLDB_REGNUM_GENERIC_FP); - if (reg_ctx->ReadRegister(pc_reg_info, reg_value)) - { - if (log) - log->Printf("Pushing the current PC onto the stack: 0x%" PRIx64 ": 0x%" PRIx64, (uint64_t)sp, reg_value.GetAsUInt64()); - - if (!process_sp->WritePointerToMemory(sp, reg_value.GetAsUInt64(), error)) - return false; - - sp -= 8; - - // Save current FP - if (reg_ctx->ReadRegister(fp_reg_info, reg_value)) - { - if (log) - log->Printf("Pushing the current FP onto the stack: 0x%" PRIx64 ": 0x%" PRIx64, (uint64_t)sp, reg_value.GetAsUInt64()); - - if (!process_sp->WritePointerToMemory(sp, reg_value.GetAsUInt64(), error)) - return false; - } - // Setup FP backchain - reg_value.SetUInt64 (sp); - - if (log) - log->Printf("Writing FP: 0x%" PRIx64 " (for FP backchain)", reg_value.GetAsUInt64()); - - if (!reg_ctx->WriteRegister(fp_reg_info, reg_value)) - { - return false; - } - - sp -= 8; - } -#endif - if (log) log->Printf("Pushing the return address onto the stack: 0x%" PRIx64 ": 0x%" PRIx64,