maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Improve BugReport diagnostics for loops and ? operator. 

llvm-svn: 49356
This commit is contained in:
Ted Kremenek 2008-04-07 23:35:17 +00:00
parent c0f15487c6
commit e73006ee45
1 changed files with 57 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
clang/lib/Analysis/BugReporter.cpp
View File

@ -41,6 +41,11 @@ static inline Stmt* GetStmt(const ProgramPoint& P) {
return NULL; return NULL;
} }
static inline Stmt* GetStmt(const CFGBlock* B) {
assert (!B->empty());
return (*B)[0];
}
PathDiagnosticPiece* PathDiagnosticPiece*
BugDescription::getEndPath(ASTContext& Ctx, ExplodedNode<ValueState> *N) const { BugDescription::getEndPath(ASTContext& Ctx, ExplodedNode<ValueState> *N) const {
@ -142,7 +147,7 @@ void BugReporter::GeneratePathDiagnostic(PathDiagnostic& PD, ASTContext& Ctx,
std::ostringstream os; std::ostringstream os;
os << "Control jumps to line " os << "Control jumps to line "
<< SMgr.getLogicalLineNumber(S->getLocStart()) << ".\n"; << SMgr.getLogicalLineNumber(S->getLocStart()) << ".\n";
PD.push_front(new PathDiagnosticPiece(L, os.str())); PD.push_front(new PathDiagnosticPiece(L, os.str()));
break; break;
@ -206,7 +211,7 @@ void BugReporter::GeneratePathDiagnostic(PathDiagnostic& PD, ASTContext& Ctx,
} }
os << ":' at line " os << ":' at line "
<< SMgr.getLogicalLineNumber(S->getLocStart()) << ".\n"; << SMgr.getLogicalLineNumber(S->getLocStart()) << ".\n";
break; break;
@ -217,10 +222,58 @@ void BugReporter::GeneratePathDiagnostic(PathDiagnostic& PD, ASTContext& Ctx,
break; break;
} }
case Stmt::ConditionalOperatorClass: {
std::ostringstream os;
os << "'?' condition evaluates to ";
if (*(Src->succ_begin()+1) == Dst)
os << "false.";
else
os << "true.";
PD.push_front(new PathDiagnosticPiece(L, os.str()));
break;
}
case Stmt::DoStmtClass: {
if (*(Src->succ_begin()) == Dst) {
std::ostringstream os;
os << "Loop condition is true. Execution continues on line "
<< SMgr.getLogicalLineNumber(GetStmt(Dst)->getLocStart()) << '.';
PD.push_front(new PathDiagnosticPiece(L, os.str()));
}
else
PD.push_front(new PathDiagnosticPiece(L,
"Loop condition is false. Exiting loop."));
break;
}
case Stmt::DoStmtClass:
case Stmt::WhileStmtClass: case Stmt::WhileStmtClass:
case Stmt::ForStmtClass: case Stmt::ForStmtClass: {
if (*(Src->succ_begin()+1) == Dst) {
std::ostringstream os;
os << "Loop condition is false. Execution continues on line "
<< SMgr.getLogicalLineNumber(GetStmt(Dst)->getLocStart()) << '.';
PD.push_front(new PathDiagnosticPiece(L, os.str()));
}
else
PD.push_front(new PathDiagnosticPiece(L,
"Loop condition is true. Entering loop body."));
break;
}
case Stmt::IfStmtClass: { case Stmt::IfStmtClass: {
if (*(Src->succ_begin()+1) == Dst) if (*(Src->succ_begin()+1) == Dst)