maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LLD] [COFF] Align all debug directories 

Match MSVC linker output - align all debug directories on four bytes,
while removing debug directory alignment. This would have the same
effect on CETCOMPAT support as D89919.

Chromium bug: https://crbug.com/1136664

Differential Revision: https://reviews.llvm.org/D89921
This commit is contained in:
Peter Penzin 2020-10-29 15:50:40 -07:00 committed by Reid Kleckner
parent 31a3aca7f9
commit e59726220f
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lld/COFF/Writer.cpp
View File

@ -978,15 +978,14 @@ void Writer::createMiscChunks() {
} }
if (config->cetCompat) { if (config->cetCompat) {
ExtendedDllCharacteristicsChunk *extendedDllChars = debugRecords.push_back({COFF::IMAGE_DEBUG_TYPE_EX_DLLCHARACTERISTICS,
make<ExtendedDllCharacteristicsChunk>( make<ExtendedDllCharacteristicsChunk>(
IMAGE_DLL_CHARACTERISTICS_EX_CET_COMPAT); IMAGE_DLL_CHARACTERISTICS_EX_CET_COMPAT)});
debugRecords.push_back(
{COFF::IMAGE_DEBUG_TYPE_EX_DLLCHARACTERISTICS, extendedDllChars});
} }
if (debugRecords.size() > 0) { // Align and add each chunk referenced by the debug data directory.
for (std::pair<COFF::DebugType, Chunk *> r : debugRecords) for (std::pair<COFF::DebugType, Chunk *> r : debugRecords) {
r.second->setAlignment(4);
debugInfoSec->addChunk(r.second); debugInfoSec->addChunk(r.second);
} }