maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Update documentation for the DialectOpconversion class: overriding `match()` is optional 

Recently a default implementation for `match()` was provided (cl/242285885), but the class documentation wasn't updated appropriately.

--

PiperOrigin-RevId: 243128738
This commit is contained in:
Mehdi Amini 2019-04-11 13:19:46 -07:00 committed by Mehdi Amini
parent 0836f670f1
commit e552a63aa1
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mlir/include/mlir/Transforms/DialectConversion.h
View File

@ -42,8 +42,10 @@ class FunctionConversion;
} }
/// Base class for the dialect op conversion patterns. Specific conversions /// Base class for the dialect op conversion patterns. Specific conversions
/// must derive this class and implement `PatternMatch match(Operation *)` /// must derive this class and implement least one of `rewrite` and
/// defined in `Pattern` and at least one of `rewrite` and `rewriteTerminator`. /// `rewriteTerminator`. Optionally they can also override
/// `PatternMatch match(Operation *)` to match more specific operations than the
/// `rootName` provided in the constructor.
// //
// TODO(zinenko): this should eventually converge with RewritePattern. So far, // TODO(zinenko): this should eventually converge with RewritePattern. So far,
// rewritePattern is missing support for operations with successors as well as // rewritePattern is missing support for operations with successors as well as