Remove one of the LLVM-specific CMake hacks in favor of standard CMake

facilities.

This was only used in one place in LLVM, and was used pervasively (but
with different code!) in Clang. It has no advantages over the standard
CMake facilities and in some cases disadvantages.

llvm-svn: 158889

llvm/cmake/modules/AddLLVM.cmake

@@ -82,7 +82,6 @@ macro(add_llvm_executable name)
     add_executable(${name} ${ALL_FILES})
   endif()
   set(EXCLUDE_FROM_ALL OFF)
-  target_link_libraries( ${name} ${LLVM_USED_LIBS} )
   llvm_config( ${name} ${LLVM_LINK_COMPONENTS} )
   if( LLVM_COMMON_DEPENDS )
     add_dependencies( ${name} ${LLVM_COMMON_DEPENDS} )

llvm/unittests/CMakeLists.txt

@@ -10,7 +10,14 @@ function(add_llvm_unittest test_dirname)
   if( NOT LLVM_BUILD_TESTS )
     set(EXCLUDE_FROM_ALL ON)
   endif()
+
   add_llvm_executable(${test_name}Tests ${ARGN})
+  target_link_libraries(${test_name}Tests
+    gtest
+    gtest_main
+    LLVMSupport # gtest needs it for raw_ostream.
+    )
+
   add_dependencies(UnitTests ${test_name}Tests)
   set_target_properties(${test_name}Tests PROPERTIES FOLDER "Tests")
 endfunction()
@@ -51,12 +58,6 @@ set(LLVM_LINK_COMPONENTS
   Support
   )
 
-set(LLVM_USED_LIBS
-  gtest
-  gtest_main
-  LLVMSupport # gtest needs it for raw_ostream.
-  )
-
 add_llvm_unittest(ADT
   ADT/APFloatTest.cpp
   ADT/APIntTest.cpp