maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Wrap the new ext-warn on extraneous comma on the last entry of an enumerator 

list in a diagnostic group so it can be turned on and off. A terrifying amount
of code, including large chunks of open source code, still do this so it's
important to be able to suppress it when necessary.

Doug, is this a reasonable compromise? I'd lean toward making it a normal
extension, but I don't feel strongly as long as we can turn the warnings off.

llvm-svn: 107865
This commit is contained in:
Chandler Carruth 2010-07-08 10:52:01 +00:00
parent dd1bc0f1b5
commit e51a119fc6
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
clang/include/clang/Basic/DiagnosticGroups.td
View File

@ -38,6 +38,7 @@ def : DiagGroup<"disabled-optimization">;
def : DiagGroup<"discard-qual">;
def : DiagGroup<"div-by-zero">;
def EmptyBody : DiagGroup<"empty-body">;
def EnumeratorListComma : DiagGroup<"enumerator-list-comma">;
def ExtraTokens : DiagGroup<"extra-tokens">;
def FormatExtraArgs : DiagGroup<"format-extra-args">;

2
clang/include/clang/Basic/DiagnosticParseKinds.td
View File

@ -53,7 +53,7 @@ def ext_c99_compound_literal : Extension<
"compound literals are a C99-specific feature">;
def ext_enumerator_list_comma : ExtWarn<
"commas at the end of enumerator lists are a %select{C99|C++0x}0-specific "
"feature">;
"feature">, InGroup<EnumeratorListComma>;
def ext_gnu_indirect_goto : Extension<
"use of GNU indirect-goto extension">, InGroup<GNU>;