maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[MC][ELF] Drop MCSymbol::isExternal call sites 

ELF uses symbol bindings and MCSymbol::isExternal is not really useful.
The function is no longer used in ELF code now.
This commit is contained in:
Fangrui Song 2020-12-20 21:18:22 -08:00
parent 553d4d08d2
commit e4c360a897
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/MC/ELFObjectWriter.cpp
View File

@ -464,7 +464,7 @@ void ELFWriter::writeHeader(const MCAssembler &Asm) {
uint64_t ELFWriter::SymbolValue(const MCSymbol &Sym, uint64_t ELFWriter::SymbolValue(const MCSymbol &Sym,
const MCAsmLayout &Layout) { const MCAsmLayout &Layout) {
if (Sym.isCommon() && (Sym.isTargetCommon() || Sym.isExternal())) if (Sym.isCommon())
return Sym.getCommonAlignment(); return Sym.getCommonAlignment();
uint64_t Res; uint64_t Res;
@ -1278,7 +1278,6 @@ void ELFObjectWriter::executePostLayoutBinding(MCAssembler &Asm,
// Aliases defined with .symvar copy the binding from the symbol they alias. // Aliases defined with .symvar copy the binding from the symbol they alias.
// This is the first place we are able to copy this information. // This is the first place we are able to copy this information.
Alias->setExternal(Symbol.isExternal());
Alias->setBinding(Symbol.getBinding()); Alias->setBinding(Symbol.getBinding());
Alias->setVisibility(Symbol.getVisibility()); Alias->setVisibility(Symbol.getVisibility());
Alias->setOther(Symbol.getOther()); Alias->setOther(Symbol.getOther());