maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert "[lldb/DWARF] Fix evaluator crash when accessing empty stack." 

This reverts commit e26eece1e2.
This commit is contained in:
Med Ismail Bennani 2020-03-31 17:44:17 +02:00
parent 31a346cc35
commit e4a778052e
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/source/Expression/DWARFExpression.cpp
View File

@ -2318,12 +2318,6 @@ bool DWARFExpression::Evaluate(
// rather is a constant value. The value from the top of the stack is the
// value to be used. This is the actual object value and not the location.
case DW_OP_stack_value:
if (stack.empty()) {
if (error_ptr)
error_ptr->SetErrorString(
"Expression stack needs at least 1 item for DW_OP_stack_value.");
return false;
}
stack.back().SetValueType(Value::eValueTypeScalar);
break;

4
lldb/unittests/Expression/DWARFExpressionTest.cpp
View File

@ -234,10 +234,6 @@ TEST(DWARFExpression, DW_OP_convert) {
llvm::Failed());
}
TEST(DWARFExpression, DW_OP_stack_value) {
EXPECT_THAT_EXPECTED(Evaluate({DW_OP_stack_value}), llvm::Failed());
}
TEST(DWARFExpression, DW_OP_piece) {
EXPECT_THAT_EXPECTED(Evaluate({DW_OP_const2u, 0x11, 0x22, DW_OP_piece, 2,
DW_OP_const2u, 0x33, 0x44, DW_OP_piece, 2}),