maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix function attribute verification check. 

Thanks Duncan!

llvm-svn: 57029
This commit is contained in:
Devang Patel 2008-10-03 21:11:02 +00:00
parent e3e45a8c43
commit e4924e1026
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/include/llvm/Attributes.h
View File

@ -54,7 +54,8 @@ const Attributes Alignment = 0xffff<<16; ///< Alignment of parameter (16 bits)
const Attributes ParameterOnly = ByVal | Nest | StructRet; const Attributes ParameterOnly = ByVal | Nest | StructRet;
/// @brief Attributes that only apply to function. /// @brief Attributes that only apply to function.
const Attributes FunctionOnly = NoReturn | NoUnwind | ReadNone | ReadOnly; const Attributes FunctionOnly = NoReturn | NoUnwind | ReadNone | ReadOnly |
NoInline | AlwaysInline | OptimizeForSize;
/// @brief Parameter attributes that do not apply to vararg call arguments. /// @brief Parameter attributes that do not apply to vararg call arguments.
const Attributes VarArgsIncompatible = StructRet; const Attributes VarArgsIncompatible = StructRet;

11
llvm/lib/VMCore/Verifier.cpp
View File

@ -415,12 +415,11 @@ void Verifier::VerifyAttrs(Attributes Attrs, const Type *Ty,
Attributes RetI = Attrs & Attribute::ParameterOnly; Attributes RetI = Attrs & Attribute::ParameterOnly;
Assert1(!RetI, "Attribute " + Attribute::getAsString(RetI) + Assert1(!RetI, "Attribute " + Attribute::getAsString(RetI) +
" does not apply to return values!", V); " does not apply to return values!", V);
} else {
Attributes ParmI = Attrs & Attribute::FunctionOnly;
Assert1(!ParmI, "Attribute " + Attribute::getAsString(ParmI) +
" only applies to return values!", V);
} }
Attributes FnCheckAttr = Attrs & Attribute::FunctionOnly;
Assert1(!FnCheckAttr, "Attribute " + Attribute::getAsString(FnCheckAttr) +
" only applies to return values!", V);
for (unsigned i = 0; for (unsigned i = 0;
i < array_lengthof(Attribute::MutuallyIncompatible); ++i) { i < array_lengthof(Attribute::MutuallyIncompatible); ++i) {
Attributes MutI = Attrs & Attribute::MutuallyIncompatible[i]; Attributes MutI = Attrs & Attribute::MutuallyIncompatible[i];
@ -477,7 +476,7 @@ void Verifier::VerifyFunctionAttrs(const FunctionType *FT,
} }
Attributes FAttrs = Attrs.getFnAttributes(); Attributes FAttrs = Attrs.getFnAttributes();
Assert1(!(FAttrs & (!Attribute::FunctionOnly)), Assert1(!(FAttrs & (~Attribute::FunctionOnly)),
"Attribute " + Attribute::getAsString(FAttrs) + "Attribute " + Attribute::getAsString(FAttrs) +
" does not apply to function!", V); " does not apply to function!", V);