From e43b6054b1d91cdf3942e243dc1c654f7a782e8b Mon Sep 17 00:00:00 2001 From: Evan Cheng Date: Wed, 20 Feb 2008 18:32:05 +0000 Subject: [PATCH] Temporarily backing out r47337. It breaks a number of CBE tests. llvm-svn: 47385 --- llvm/lib/Target/CBackend/CBackend.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/llvm/lib/Target/CBackend/CBackend.cpp b/llvm/lib/Target/CBackend/CBackend.cpp index 305c8de3740b..91ca97e9ef53 100644 --- a/llvm/lib/Target/CBackend/CBackend.cpp +++ b/llvm/lib/Target/CBackend/CBackend.cpp @@ -1198,12 +1198,12 @@ void CWriter::writeOperandRaw(Value *Operand) { } void CWriter::writeOperand(Value *Operand) { - if (isa(Operand) || isDirectAlloca(Operand) || ByValParams.count(Operand)) + if (isa(Operand) || isDirectAlloca(Operand)) Out << "(&"; // Global variables are referenced as their addresses by llvm writeOperandInternal(Operand); - if (isa(Operand) || isDirectAlloca(Operand) || ByValParams.count(Operand)) + if (isa(Operand) || isDirectAlloca(Operand)) Out << ')'; } @@ -2723,11 +2723,13 @@ void CWriter::visitCallInst(CallInst &I) { // Check if the argument is expected to be passed by value. bool isOutByVal = PAL && PAL->paramHasAttr(ArgNo+1, ParamAttr::ByVal); // Check if this argument itself is passed in by reference. - //bool isInByVal = ByValParams.count(*AI); - if (isOutByVal) + bool isInByVal = ByValParams.count(*AI); + if (isOutByVal && !isInByVal) Out << "*("; + else if (!isOutByVal && isInByVal) + Out << "&("; writeOperand(*AI); - if (isOutByVal) + if (isOutByVal ^ isInByVal) Out << ")"; PrintedArg = true; }