From e315ce2bd3a5347ab58d50fab2d449e8a4e60e00 Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Thu, 9 Jan 2020 12:05:30 +0000 Subject: [PATCH] Fix "pointer is null" static analyzer warnings. NFCI. Use castAs<> instead of getAs<> since the pointer is dereferenced immediately below and castAs will perform the null assertion for us. --- clang/lib/Sema/SemaCoroutine.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/lib/Sema/SemaCoroutine.cpp b/clang/lib/Sema/SemaCoroutine.cpp index 271c4a10f3e4..6dc9e342beb9 100644 --- a/clang/lib/Sema/SemaCoroutine.cpp +++ b/clang/lib/Sema/SemaCoroutine.cpp @@ -1228,7 +1228,7 @@ bool CoroutineStmtBuilder::makeNewAndDeleteExpr() { return false; if (RequiresNoThrowAlloc) { - const auto *FT = OperatorNew->getType()->getAs(); + const auto *FT = OperatorNew->getType()->castAs(); if (!FT->isNothrow(/*ResultIfDependent*/ false)) { S.Diag(OperatorNew->getLocation(), diag::err_coroutine_promise_new_requires_nothrow) @@ -1281,7 +1281,7 @@ bool CoroutineStmtBuilder::makeNewAndDeleteExpr() { // Check if we need to pass the size. const auto *OpDeleteType = - OpDeleteQualType.getTypePtr()->getAs(); + OpDeleteQualType.getTypePtr()->castAs(); if (OpDeleteType->getNumParams() > 1) DeleteArgs.push_back(FrameSize);