Relax assertion to account for private framework modules, too.

rdar://problem/48116069

llvm-svn: 354165
This commit is contained in:
Adrian Prantl 2019-02-15 20:24:26 +00:00
parent 4b512c36b6
commit e308e4299d
2 changed files with 5 additions and 5 deletions

View File

@ -2299,8 +2299,8 @@ CGDebugInfo::getOrCreateModuleRef(ExternalASTSource::ASTSourceDescriptor Mod,
// When a module name is specified as -fmodule-name, that module gets a
// clang::Module object, but it won't actually be built or imported; it will
// be textual.
if (CreateSkeletonCU && IsRootModule && Mod.getASTFile().empty())
assert((!M || (M->Name == CGM.getLangOpts().ModuleName)) &&
if (CreateSkeletonCU && IsRootModule && Mod.getASTFile().empty() && M)
assert(StringRef(M->Name).startswith(CGM.getLangOpts().ModuleName) &&
"clang module without ASTFile must be specified by -fmodule-name");
if (CreateSkeletonCU && IsRootModule && !Mod.getASTFile().empty()) {

View File

@ -1,16 +1,16 @@
// RUN: rm -rf %t
// RUN: %clang_cc1 -fmodules -fmodule-format=obj -fmodule-name=F \
// RUN: %clang_cc1 -fmodules -fmodule-format=obj -fmodule-name=MainA \
// RUN: -debug-info-kind=limited -dwarf-ext-refs \
// RUN: -fimplicit-module-maps -x c -fmodules-cache-path=%t -F %S/Inputs \
// RUN: %s -S -emit-llvm -debugger-tuning=lldb -o - | FileCheck %s
#include "F/F.h"
#include "MainA/MainPriv.h"
// CHECK: !DICompileUnit
// CHECK-NOT: dwoId:
// We still want the import, but no skeleton CU, since no PCM was built.
// CHECK: !DIModule({{.*}}, name: "F"
// CHECK: !DIModule({{.*}}, name: "APriv"
// CHECK-NOT: !DICompileUnit
// CHECK-NOT: dwoId: