[Coverage] Delete getCounterMismatches, it's dead code (NFC)

Exactly one counted region is inserted into a function record for every
region in a coverage mapping.

llvm-svn: 339193
This commit is contained in:
Vedant Kumar 2018-08-07 22:25:22 +00:00
parent ffa9d2e404
commit e302fc597a
3 changed files with 1 additions and 23 deletions

View File

@ -510,7 +510,6 @@ class CoverageMapping {
DenseMap<size_t, DenseSet<size_t>> RecordProvenance; DenseMap<size_t, DenseSet<size_t>> RecordProvenance;
std::vector<FunctionRecord> Functions; std::vector<FunctionRecord> Functions;
std::vector<std::pair<std::string, uint64_t>> FuncHashMismatches; std::vector<std::pair<std::string, uint64_t>> FuncHashMismatches;
std::vector<std::pair<std::string, uint64_t>> FuncCounterMismatches;
CoverageMapping() = default; CoverageMapping() = default;
@ -537,9 +536,7 @@ public:
/// ///
/// This is a count of functions whose profile is out of date or otherwise /// This is a count of functions whose profile is out of date or otherwise
/// can't be associated with any coverage information. /// can't be associated with any coverage information.
unsigned getMismatchedCount() const { unsigned getMismatchedCount() const { return FuncHashMismatches.size(); }
return FuncHashMismatches.size() + FuncCounterMismatches.size();
}
/// A hash mismatch occurs when a profile record for a symbol does not have /// A hash mismatch occurs when a profile record for a symbol does not have
/// the same hash as a coverage mapping record for the same symbol. This /// the same hash as a coverage mapping record for the same symbol. This
@ -549,14 +546,6 @@ public:
return FuncHashMismatches; return FuncHashMismatches;
} }
/// A counter mismatch occurs when there is an error when evaluating the
/// counter expressions in a coverage mapping record. This returns a list of
/// counter mismatches, where each mismatch is a pair of the symbol name and
/// the number of valid evaluated counter expressions.
ArrayRef<std::pair<std::string, uint64_t>> getCounterMismatches() const {
return FuncCounterMismatches;
}
/// Returns a lexicographically sorted, unique list of files that are /// Returns a lexicographically sorted, unique list of files that are
/// covered. /// covered.
std::vector<StringRef> getUniqueSourceFiles() const; std::vector<StringRef> getUniqueSourceFiles() const;

View File

@ -239,11 +239,6 @@ Error CoverageMapping::loadFunctionRecord(
} }
Function.pushRegion(Region, *ExecutionCount); Function.pushRegion(Region, *ExecutionCount);
} }
if (Function.CountedRegions.size() != Record.MappingRegions.size()) {
FuncCounterMismatches.emplace_back(Record.FunctionName,
Function.CountedRegions.size());
return Error::success();
}
Functions.push_back(std::move(Function)); Functions.push_back(std::move(Function));
return Error::success(); return Error::success();

View File

@ -368,12 +368,6 @@ std::unique_ptr<CoverageMapping> CodeCoverageTool::load() {
<< "No profile record found for '" << HashMismatch.first << "'" << "No profile record found for '" << HashMismatch.first << "'"
<< " with hash = 0x" << Twine::utohexstr(HashMismatch.second) << " with hash = 0x" << Twine::utohexstr(HashMismatch.second)
<< '\n'; << '\n';
for (const auto &CounterMismatch : Coverage->getCounterMismatches())
errs() << "counter-mismatch: "
<< "Coverage mapping for " << CounterMismatch.first
<< " only has " << CounterMismatch.second
<< " valid counter expressions\n";
} }
} }