maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang] Add check for conflict of BIND(C) and Parameter attributes 

The entity with BIND(C) attribute cannot be a named constant, so the
BIND(C) and parameter attributes are conflicted. Add check for it.

Reviewed By: klausler

Differential Revision: https://reviews.llvm.org/D126654
This commit is contained in:
PeixinQiao 2022-06-02 20:58:05 +08:00
parent 30ad481e87
commit e2ac99b79d
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
flang/lib/Semantics/check-declarations.cpp
View File

@ -1873,11 +1873,11 @@ static const std::string *DefinesBindCName(const Symbol &symbol) {
}
}
// Check that BIND(C) names are distinct and BIND(C) variable declared in module
void CheckHelper::CheckBindC(const Symbol &symbol) {
if (!symbol.attrs().test(Attr::BIND_C)) {
return;
}
CheckConflicting(symbol, Attr::BIND_C, Attr::PARAMETER);
if (symbol.has<ObjectEntityDetails>() && !symbol.owner().IsModule()) {
messages_.Say(symbol.name(),
"A variable with BIND(C) attribute may only appear in the specification part of a module"_err_en_US);

32
flang/test/Semantics/declarations02.f90 Normal file
View File

@ -0,0 +1,32 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
module m
!ERROR: 'x1' may not have both the BIND(C) and PARAMETER attributes
integer, parameter, bind(c, name="a") :: x1 = 1
!ERROR: 'x2' may not have both the BIND(C) and PARAMETER attributes
integer, bind(c), parameter :: x2 = 1
!ERROR: 'x3' may not have both the BIND(C) and PARAMETER attributes
integer, parameter :: x3 = 1
bind(c) :: x3
type :: my_type1
integer :: x4
end type
type, bind(c) :: my_type2
integer :: x5
end type
!ERROR: 't1' may not have both the BIND(C) and PARAMETER attributes
type(my_type1), bind(c), parameter :: t1 = my_type1(1)
!ERROR: 't2' may not have both the BIND(C) and PARAMETER attributes
type(my_type2), bind(c), parameter :: t2 = my_type2(1)
type(my_type2), parameter :: t3 = my_type2(1) ! no error
!ERROR: 't4' may not have both the BIND(C) and PARAMETER attributes
type(my_type1), parameter :: t4 = my_type1(1)
!ERROR: 't5' may not have both the BIND(C) and PARAMETER attributes
type(my_type2), parameter :: t5 = my_type2(1)
bind(c) :: t4, t5
end