maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[BitcodeReader] Infer the correct runtime preemption for GlobalValue 

Summary:
To allow bitcode built by old compiler to pass the current verifer,
BitcodeReader needs to auto infer the correct runtime preemption from
linkage and visibility for GlobalValues.

Since llvm-6.0 bitcode already contains the new field but can be
incorrect in some cases, the attribute needs to be recomputed all the
time in BitcodeReader. This will make all the GVs has dso_local marked
correctly if read from bitcode, and it should still allow the verifier
to catch mistakes in optimization passes.

This should fix PR38009.

Reviewers: sfertile, vsk

Reviewed By: vsk

Subscribers: dexonsmith, llvm-commits

Differential Revision: https://reviews.llvm.org/D49039

llvm-svn: 336560
This commit is contained in:
Steven Wu 2018-07-09 16:52:05 +00:00
parent 75c348a097
commit e1f7c5f8c7
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
llvm/lib/Bitcode/Reader/BitcodeReader.cpp
View File

@ -2831,6 +2831,13 @@ Error BitcodeReader::parseComdatRecord(ArrayRef<uint64_t> Record) {
return Error::success();
}
static void inferDSOLocal(GlobalValue *GV) {
// infer dso_local from linkage and visibility if it is not encoded.
if (GV->hasLocalLinkage() ||
(!GV->hasDefaultVisibility() && !GV->hasExternalWeakLinkage()))
GV->setDSOLocal(true);
}
Error BitcodeReader::parseGlobalVarRecord(ArrayRef<uint64_t> Record) {
// v1: [pointer type, isconst, initid, linkage, alignment, section,
// visibility, threadlocal, unnamed_addr, externally_initialized,
@ -2923,6 +2930,7 @@ Error BitcodeReader::parseGlobalVarRecord(ArrayRef<uint64_t> Record) {
if (Record.size() > 13) {
NewGV->setDSOLocal(getDecodedDSOLocal(Record[13]));
}
inferDSOLocal(NewGV);
return Error::success();
}
@ -3007,6 +3015,7 @@ Error BitcodeReader::parseFunctionRecord(ArrayRef<uint64_t> Record) {
if (Record.size() > 15) {
Func->setDSOLocal(getDecodedDSOLocal(Record[15]));
}
inferDSOLocal(Func);
ValueList.push_back(Func);
@ -3083,6 +3092,8 @@ Error BitcodeReader::parseGlobalIndirectSymbolRecord(
}
if (OpNum != Record.size())
NewGA->setDSOLocal(getDecodedDSOLocal(Record[OpNum++]));
inferDSOLocal(NewGA);
ValueList.push_back(NewGA);
IndirectSymbolInits.push_back(std::make_pair(NewGA, Val));
return Error::success();

BIN
llvm/test/Bitcode/Inputs/infer_dso_local.bc Normal file
View File

Binary file not shown.

3
llvm/test/Bitcode/infer_dso_local.ll Normal file
View File

@ -0,0 +1,3 @@
; RUN: opt -verify %S/Inputs/infer_dso_local.bc | llvm-dis | FileCheck %s
; CHECK: define linkonce_odr hidden void @test()