maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc][NFC] remove completed TODOs 

There were some "TODO" messages that were for things that I have already
completed. This patch removes those.

Reviewed By: michaelrj

Differential Revision: https://reviews.llvm.org/D121232
This commit is contained in:
Michael Jones 2022-03-08 10:19:31 -08:00
parent bf0ded805a
commit e1dcda966e
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libc/src/__support/str_to_float.h
View File

@ -21,8 +21,6 @@ namespace __llvm_libc {
namespace internal {
template <class T> uint32_t inline leading_zeroes(T inputNumber) {
// TODO(michaelrj): investigate the portability of using something like
// __builtin_clz for specific types.
constexpr uint32_t BITS_IN_T = sizeof(T) * 8;
if (inputNumber == 0) {
return BITS_IN_T;

12
libc/test/src/__support/str_to_float_test.cpp
View File

@ -259,18 +259,6 @@ TEST(LlvmLibcStrToFloatTest, SimpleDecimalConversionExtraTypes) {
EXPECT_EQ(double_output_mantissa, uint64_t(0x1AC53A7E04BCDA));
EXPECT_EQ(output_exp2, uint32_t(1089));
EXPECT_EQ(errno, 0);
// TODO(michaelrj): Get long double support working.
// __uint128_t longDoubleOutputMantissa = 0;
// outputExp2 = 0;
// errno = 0;
// __llvm_libc::internal::simple_decimal_conversion<long double>(
// "123456789012345678900", &longDoubleOutputMantissa, &outputExp2);
// EXPECT_EQ(longDoubleOutputMantissa, __uint128_t(0x1AC53A7E04BCDA));
// EXPECT_EQ(outputExp2, uint32_t(1089));
// EXPECT_EQ(errno, 0);
}
#if defined(LONG_DOUBLE_IS_DOUBLE)