From e15ab8f277c71c6843537ffdca7ca9f5eea0b9ea Mon Sep 17 00:00:00 2001 From: Johannes Doerfert Date: Thu, 31 Oct 2019 13:46:43 -0500 Subject: [PATCH] [InstCombine] Add the test that triggered the D60846 revert This is in preparation of D69571. --- .../Transforms/InstCombine/known-non-zero.ll | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/llvm/test/Transforms/InstCombine/known-non-zero.ll b/llvm/test/Transforms/InstCombine/known-non-zero.ll index 0329fbaf9904..57980e0890c2 100644 --- a/llvm/test/Transforms/InstCombine/known-non-zero.ll +++ b/llvm/test/Transforms/InstCombine/known-non-zero.ll @@ -91,3 +91,45 @@ exit: %res = phi <8 x i64> [ %ctz, %non_zero ], [ zeroinitializer, %start ] ret <8 x i64> %res } + +; Test that exposed a bug in the PHI handling after D60846. No folding should happen here! +define void @D60846_misompile(i1* %p) { +; CHECK-LABEL: @D60846_misompile( +; CHECK-NEXT: entry: +; CHECK-NEXT: br label [[LOOP:%.*]] +; CHECK: loop: +; CHECK-NEXT: [[I:%.*]] = phi i16 [ 0, [[ENTRY:%.*]] ], [ [[I_INC:%.*]], [[COMMON:%.*]] ] +; CHECK-NEXT: [[IS_ZERO:%.*]] = icmp eq i16 [[I]], 0 +; CHECK-NEXT: br i1 [[IS_ZERO]], label [[COMMON]], label [[NON_ZERO:%.*]] +; CHECK: non_zero: +; CHECK-NEXT: [[IS_ONE:%.*]] = icmp eq i16 [[I]], 1 +; CHECK-NEXT: store i1 [[IS_ONE]], i1* [[P:%.*]], align 1 +; CHECK-NEXT: br label [[COMMON]] +; CHECK: common: +; CHECK-NEXT: [[I_INC]] = add i16 [[I]], 1 +; CHECK-NEXT: [[LOOP_COND:%.*]] = icmp ult i16 [[I_INC]], 2 +; CHECK-NEXT: br i1 [[LOOP_COND]], label [[LOOP]], label [[EXIT:%.*]] +; CHECK: exit: +; CHECK-NEXT: ret void +; +entry: + br label %loop + +loop: ; preds = %common, %entry + %i = phi i16 [ 0, %entry ], [ %i.inc, %common ] + %is_zero = icmp eq i16 %i, 0 + br i1 %is_zero, label %common, label %non_zero + +non_zero: ; preds = %loop + %is_one = icmp eq i16 %i, 1 + store i1 %is_one, i1* %p + br label %common + +common: ; preds = %non_zero, %loop + %i.inc = add i16 %i, 1 + %loop_cond = icmp ult i16 %i.inc, 2 + br i1 %loop_cond, label %loop, label %exit + +exit: ; preds = %common + ret void +}