maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix clang Wrange-loop-analysis in BuildTree.cpp 

Building on Mac OS with clang 12:

```
jhemphill@jhemphill-mbp build % clang --version
Apple clang version 12.0.0 (clang-1200.0.26.2)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
```

yields one warning:

```
/Users/jhemphill/oss/llvm-project/clang/lib/Tooling/Syntax/BuildTree.cpp:1126:22: warning: loop variable 'Arg' is always a copy because the range of type 'llvm::iterator_range<clang::Stmt::CastIterator<clang::Expr, clang::Expr *, clang::Stmt *> >' does not return a reference [-Wrange-loop-analysis]
    for (const auto &Arg : Args) {
                     ^
/Users/jhemphill/oss/llvm-project/clang/lib/Tooling/Syntax/BuildTree.cpp:1126:10: note: use non-reference type 'clang::Expr *'
    for (const auto &Arg : Args) {
```

It appears that `Arg` is an `Expr*`, passed by value rather than by const reference.

Reviewed By: eduucaldas, gribozavr2

Differential Revision: https://reviews.llvm.org/D87482
This commit is contained in:
Dmitri Gribenko 2020-09-12 01:07:54 +02:00
parent 658475897b
commit e10df779f0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/Tooling/Syntax/BuildTree.cpp
View File

@ -1126,7 +1126,7 @@ public:
syntax::CallArguments * syntax::CallArguments *
buildCallArguments(CallExpr::arg_range ArgsAndDefaultArgs) { buildCallArguments(CallExpr::arg_range ArgsAndDefaultArgs) {
auto Args = dropDefaultArgs(ArgsAndDefaultArgs); auto Args = dropDefaultArgs(ArgsAndDefaultArgs);
for (const auto &Arg : Args) { for (auto *Arg : Args) {
Builder.markExprChild(Arg, syntax::NodeRole::ListElement); Builder.markExprChild(Arg, syntax::NodeRole::ListElement);
const auto *DelimiterToken = const auto *DelimiterToken =
std::next(Builder.findToken(Arg->getEndLoc())); std::next(Builder.findToken(Arg->getEndLoc()));