forked from OSchip/llvm-project
Do not print include_next/pragma once warnings when input is a header.
r276653 suppressed the pragma once warning when generating a PCH file. This patch extends that to any main file for which clang is told (with the -x option) that it's a header file. It will also suppress the warning "#include_next in primary source file". Differential Revision: http://reviews.llvm.org/D25989 llvm-svn: 285295
This commit is contained in:
parent
7cc713adcb
commit
e0bde7554c
|
@ -132,6 +132,10 @@ public:
|
||||||
/// host code generation.
|
/// host code generation.
|
||||||
std::string OMPHostIRFile;
|
std::string OMPHostIRFile;
|
||||||
|
|
||||||
|
/// \brief Indicates whether the front-end is explicitly told that the
|
||||||
|
/// input is a header file (i.e. -x c-header).
|
||||||
|
bool IsHeaderFile;
|
||||||
|
|
||||||
LangOptions();
|
LangOptions();
|
||||||
|
|
||||||
// Define accessors/mutators for language options of enumeration type.
|
// Define accessors/mutators for language options of enumeration type.
|
||||||
|
|
|
@ -15,7 +15,8 @@
|
||||||
|
|
||||||
using namespace clang;
|
using namespace clang;
|
||||||
|
|
||||||
LangOptions::LangOptions() {
|
LangOptions::LangOptions()
|
||||||
|
: IsHeaderFile(false) {
|
||||||
#define LANGOPT(Name, Bits, Default, Description) Name = Default;
|
#define LANGOPT(Name, Bits, Default, Description) Name = Default;
|
||||||
#define ENUM_LANGOPT(Name, Type, Bits, Default, Description) set##Name(Default);
|
#define ENUM_LANGOPT(Name, Type, Bits, Default, Description) set##Name(Default);
|
||||||
#include "clang/Basic/LangOptions.def"
|
#include "clang/Basic/LangOptions.def"
|
||||||
|
@ -34,6 +35,7 @@ void LangOptions::resetNonModularOptions() {
|
||||||
SanitizerBlacklistFiles.clear();
|
SanitizerBlacklistFiles.clear();
|
||||||
|
|
||||||
CurrentModule.clear();
|
CurrentModule.clear();
|
||||||
|
IsHeaderFile = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
bool LangOptions::isNoBuiltinFunc(StringRef FuncName) const {
|
bool LangOptions::isNoBuiltinFunc(StringRef FuncName) const {
|
||||||
|
|
|
@ -1111,7 +1111,8 @@ static bool parseTestModuleFileExtensionArg(StringRef Arg,
|
||||||
}
|
}
|
||||||
|
|
||||||
static InputKind ParseFrontendArgs(FrontendOptions &Opts, ArgList &Args,
|
static InputKind ParseFrontendArgs(FrontendOptions &Opts, ArgList &Args,
|
||||||
DiagnosticsEngine &Diags) {
|
DiagnosticsEngine &Diags,
|
||||||
|
bool &IsHeaderFile) {
|
||||||
using namespace options;
|
using namespace options;
|
||||||
Opts.ProgramAction = frontend::ParseSyntaxOnly;
|
Opts.ProgramAction = frontend::ParseSyntaxOnly;
|
||||||
if (const Arg *A = Args.getLastArg(OPT_Action_Group)) {
|
if (const Arg *A = Args.getLastArg(OPT_Action_Group)) {
|
||||||
|
@ -1358,6 +1359,13 @@ static InputKind ParseFrontendArgs(FrontendOptions &Opts, ArgList &Args,
|
||||||
if (DashX == IK_None)
|
if (DashX == IK_None)
|
||||||
Diags.Report(diag::err_drv_invalid_value)
|
Diags.Report(diag::err_drv_invalid_value)
|
||||||
<< A->getAsString(Args) << A->getValue();
|
<< A->getAsString(Args) << A->getValue();
|
||||||
|
IsHeaderFile = llvm::StringSwitch<bool>(A->getValue())
|
||||||
|
.Case("c-header", true)
|
||||||
|
.Case("cl-header", true)
|
||||||
|
.Case("objective-c-header", true)
|
||||||
|
.Case("c++-header", true)
|
||||||
|
.Case("objective-c++-header", true)
|
||||||
|
.Default(false);
|
||||||
}
|
}
|
||||||
|
|
||||||
// '-' is the default input if none is given.
|
// '-' is the default input if none is given.
|
||||||
|
@ -2415,7 +2423,8 @@ bool CompilerInvocation::CreateFromArgs(CompilerInvocation &Res,
|
||||||
ParseCommentArgs(LangOpts.CommentOpts, Args);
|
ParseCommentArgs(LangOpts.CommentOpts, Args);
|
||||||
ParseFileSystemArgs(Res.getFileSystemOpts(), Args);
|
ParseFileSystemArgs(Res.getFileSystemOpts(), Args);
|
||||||
// FIXME: We shouldn't have to pass the DashX option around here
|
// FIXME: We shouldn't have to pass the DashX option around here
|
||||||
InputKind DashX = ParseFrontendArgs(Res.getFrontendOpts(), Args, Diags);
|
InputKind DashX = ParseFrontendArgs(Res.getFrontendOpts(), Args, Diags,
|
||||||
|
LangOpts.IsHeaderFile);
|
||||||
ParseTargetArgs(Res.getTargetOpts(), Args, Diags);
|
ParseTargetArgs(Res.getTargetOpts(), Args, Diags);
|
||||||
Success &= ParseCodeGenArgs(Res.getCodeGenOpts(), Args, DashX, Diags,
|
Success &= ParseCodeGenArgs(Res.getCodeGenOpts(), Args, DashX, Diags,
|
||||||
Res.getTargetOpts());
|
Res.getTargetOpts());
|
||||||
|
|
|
@ -2058,7 +2058,11 @@ void Preprocessor::HandleIncludeNextDirective(SourceLocation HashLoc,
|
||||||
// diagnostic.
|
// diagnostic.
|
||||||
const DirectoryLookup *Lookup = CurDirLookup;
|
const DirectoryLookup *Lookup = CurDirLookup;
|
||||||
const FileEntry *LookupFromFile = nullptr;
|
const FileEntry *LookupFromFile = nullptr;
|
||||||
if (isInPrimaryFile()) {
|
if (isInPrimaryFile() && LangOpts.IsHeaderFile) {
|
||||||
|
// If the main file is a header, then it's either for PCH/AST generation,
|
||||||
|
// or libclang opened it. Either way, handle it as a normal include below
|
||||||
|
// and do not complain about include_next.
|
||||||
|
} else if (isInPrimaryFile()) {
|
||||||
Lookup = nullptr;
|
Lookup = nullptr;
|
||||||
Diag(IncludeNextTok, diag::pp_include_next_in_primary);
|
Diag(IncludeNextTok, diag::pp_include_next_in_primary);
|
||||||
} else if (CurSubmodule) {
|
} else if (CurSubmodule) {
|
||||||
|
|
|
@ -1421,7 +1421,11 @@ static bool EvaluateHasIncludeNext(Token &Tok,
|
||||||
// Preprocessor::HandleIncludeNextDirective.
|
// Preprocessor::HandleIncludeNextDirective.
|
||||||
const DirectoryLookup *Lookup = PP.GetCurDirLookup();
|
const DirectoryLookup *Lookup = PP.GetCurDirLookup();
|
||||||
const FileEntry *LookupFromFile = nullptr;
|
const FileEntry *LookupFromFile = nullptr;
|
||||||
if (PP.isInPrimaryFile()) {
|
if (PP.isInPrimaryFile() && PP.getLangOpts().IsHeaderFile) {
|
||||||
|
// If the main file is a header, then it's either for PCH/AST generation,
|
||||||
|
// or libclang opened it. Either way, handle it as a normal include below
|
||||||
|
// and do not complain about __has_include_next.
|
||||||
|
} else if (PP.isInPrimaryFile()) {
|
||||||
Lookup = nullptr;
|
Lookup = nullptr;
|
||||||
PP.Diag(Tok, diag::pp_include_next_in_primary);
|
PP.Diag(Tok, diag::pp_include_next_in_primary);
|
||||||
} else if (PP.getCurrentSubmodule()) {
|
} else if (PP.getCurrentSubmodule()) {
|
||||||
|
|
|
@ -372,8 +372,10 @@ void Preprocessor::HandleMicrosoft__pragma(Token &Tok) {
|
||||||
///
|
///
|
||||||
void Preprocessor::HandlePragmaOnce(Token &OnceTok) {
|
void Preprocessor::HandlePragmaOnce(Token &OnceTok) {
|
||||||
// Don't honor the 'once' when handling the primary source file, unless
|
// Don't honor the 'once' when handling the primary source file, unless
|
||||||
// this is a prefix to a TU, which indicates we're generating a PCH file.
|
// this is a prefix to a TU, which indicates we're generating a PCH file, or
|
||||||
if (isInPrimaryFile() && TUKind != TU_Prefix) {
|
// when the main file is a header (e.g. when -xc-header is provided on the
|
||||||
|
// commandline).
|
||||||
|
if (isInPrimaryFile() && TUKind != TU_Prefix && !getLangOpts().IsHeaderFile) {
|
||||||
Diag(OnceTok, diag::pp_pragma_once_in_main_file);
|
Diag(OnceTok, diag::pp_pragma_once_in_main_file);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
|
@ -0,0 +1,8 @@
|
||||||
|
// RUN: %clang_cc1 -x c-header -ffreestanding -Eonly -verify %s
|
||||||
|
// expected-no-diagnostics
|
||||||
|
|
||||||
|
#pragma once
|
||||||
|
#include_next "stdint.h"
|
||||||
|
#if !__has_include_next("stdint.h")
|
||||||
|
#error "__has_include_next failed"
|
||||||
|
#endif
|
Loading…
Reference in New Issue