maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lld-macho] Avoid using bump-alloc in TrieBuider 

The code can be used in multi-threads and the allocator is not thread safe.

fixes PR/54378

Reviewed By: int3, #lld-macho

Differential Revision: https://reviews.llvm.org/D121638
This commit is contained in:
Vy Nguyen 2022-03-14 17:22:24 -04:00 committed by Jez Ng
parent edd3e705bb
commit e049a87f04
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lld/MachO/ExportTrie.cpp
View File

@ -145,8 +145,13 @@ void TrieNode::writeTo(uint8_t *buf) const {
} }
} }
TrieNode::~TrieNode() {
for (TrieNode *node : nodes)
delete node;
}
TrieNode *TrieBuilder::makeNode() { TrieNode *TrieBuilder::makeNode() {
auto *node = make<TrieNode>(); auto *node = new TrieNode();
nodes.emplace_back(node); nodes.emplace_back(node);
return node; return node;
} }

1
lld/MachO/ExportTrie.h
View File

@ -22,6 +22,7 @@ class Symbol;
class TrieBuilder { class TrieBuilder {
public: public:
~TrieBuilder();
void setImageBase(uint64_t addr) { imageBase = addr; } void setImageBase(uint64_t addr) { imageBase = addr; }
void addSymbol(const Symbol &sym) { exported.push_back(&sym); } void addSymbol(const Symbol &sym) { exported.push_back(&sym); }
// Returns the size in bytes of the serialized trie. // Returns the size in bytes of the serialized trie.