From e00c986897ea6e52e1119adecee361433eed13e7 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Thu, 24 Jan 2013 08:20:11 +0000 Subject: [PATCH] clang/GlobalModuleIndex: Don't open the same file twice. Use raw_fd_ostream(fd, ...) instead. FIXME: PathV2::unique_file() is assumed to open the file with binary mode on win32. llvm-svn: 173330 --- clang/lib/Serialization/GlobalModuleIndex.cpp | 4 +--- clang/test/Modules/global_index.m | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/clang/lib/Serialization/GlobalModuleIndex.cpp b/clang/lib/Serialization/GlobalModuleIndex.cpp index 3b60979e75cf..1600e357dda9 100644 --- a/clang/lib/Serialization/GlobalModuleIndex.cpp +++ b/clang/lib/Serialization/GlobalModuleIndex.cpp @@ -507,9 +507,7 @@ GlobalModuleIndex::writeIndex(FileManager &FileMgr, StringRef Path) { return EC_IOError; // Open the temporary global index file for output. - std::string ErrorInfo; - llvm::raw_fd_ostream Out(IndexTmpPath.c_str(), ErrorInfo, - llvm::raw_fd_ostream::F_Binary); + llvm::raw_fd_ostream Out(TmpFD, true); if (Out.has_error()) return EC_IOError; diff --git a/clang/test/Modules/global_index.m b/clang/test/Modules/global_index.m index 2af18c41b660..423e1113e4f1 100644 --- a/clang/test/Modules/global_index.m +++ b/clang/test/Modules/global_index.m @@ -1,8 +1,6 @@ // RUN: rm -rf %t // RUN: %clang_cc1 -Wauto-import -fmodule-cache-path %t -fdisable-module-hash -fmodules -generate-module-index -F %S/Inputs %s -verify // RUN: ls %t|grep modules.idx -// REQUIRES: shell -// XFAIL: mingw32 // expected-no-diagnostics @import DependsOnModule;